refactoring

code-rhapsodie · Nov 14, 2023 · e231573 · e231573
1 parent 7188c86
commit e231573
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/bundle/Command/InstallCommand.php b/bundle/Command/InstallCommand.php
@@ -18,7 +18,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
-#[AsCommand('ibexamailing:install')]
+#[AsCommand(name: 'ibexamailing:install', description: 'Add IbexaMailing tables to database')]
 class InstallCommand extends Command
 {
 

diff --git a/bundle/Command/MigrateNovaEzMailingCommand.php b/bundle/Command/MigrateNovaEzMailingCommand.php
@@ -9,7 +9,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
-#[AsCommand('ibexamailing:migrate:novaezmailing')]
+#[AsCommand(name: 'ibexamailing:migrate:novaezmailing', description: 'Migrate data from old structure')]
 class MigrateNovaEzMailingCommand extends Command
 {
     private const TABLES = [

diff --git a/bundle/Listener/TopMenu.php b/bundle/Listener/TopMenu.php
@@ -21,6 +21,11 @@ public function onMainMenuConfigure(ConfigureMenuEvent $event): void
             [
                 'route' => 'ibexamailing_dashboard_index',
                 'label' => 'Ibexa Mailing',
+                'extras' => [
+                    'routes' => [
+                        'ibexamailing' => '_ibexamailing_bundle',
+                    ],
+                ],
             ]
         );
     }

diff --git a/bundle/Resources/doc/INSTALL.md b/bundle/Resources/doc/INSTALL.md
@@ -80,20 +80,10 @@ ibexamailing:
             mailing_mailer: "main"
 ```
 
-Add DoctrineMigration Folder in `doctrine_migrations.yaml`
-
-```yaml
-doctrine_migrations:
-    migrations_paths:
-        ...
-        'IbexaMailingBundle': '%kernel.project_dir%/vendor/code-rhapsodie/ibexamailingbundle/migrations'
-```
-
 ### Add the tables
 
 ```bash
-bin/console doctrine:migration:migrate IbexaMailingBundle\Version20231113102632
-bin/console doctrine:migration:migrate IbexaMailingBundle\Version20231113113924
+bin/console ibexamailing:install
 ```
 
 ### Specify the Default Mailing List Id