Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Add-Solution functionality where user can add their submission to solution so other can see it. #44

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ArpitBlagan
Copy link

On successful submission we can add it to solution where other can see his solution for better understanding.
Video link: https://www.loom.com/share/9d85ed98ef3345a89fad7a518f2eed91?sid=2a94faab-a803-4f11-88b7-468e4bfee04b

@SujithThirumalaisamy
Copy link
Contributor

Great work! I have a small suggession. Can we make the solution thing whole as a markdown? so that It will be easy and also we don't need to render the editor there. Your take on this bhaiya? @hkirat

@ArpitBlagan
Copy link
Author

Thanks!
I don't understand what you mean by 'making the whole thing Markdown' and which editor not to render. Can you please elaborate?

@SujithThirumalaisamy
Copy link
Contributor

image
Here we are rendering the code inside the code editor. I think we can get rid of that. And use a markdown to render the thing. Or something like a code snippet component

@SujithThirumalaisamy
Copy link
Contributor

Also we can make the explanation section as markdown. So that people can bold and do some needed stuffs. Rather than a plain text

@ArpitBlagan
Copy link
Author

ArpitBlagan commented Jun 17, 2024

Something like this at the time of adding solution and while showing the solution simple show the right part.

Screenshot 2024-06-17 at 11 02 24 AM

@SujithThirumalaisamy
Copy link
Contributor

Something like this at the time of adding solution and while showing the solution simple show the right part.

Screenshot 2024-06-17 at 11 02 24 AM

Yeah this is the on. Great work. Are you merging this markdown editor?

@ArpitBlagan
Copy link
Author

ArpitBlagan commented Jun 17, 2024

yup working on it. Thanks for your suggestion🙏🏼.

@ArpitBlagan
Copy link
Author

ArpitBlagan commented Jun 17, 2024

check this out
link: https://www.loom.com/share/5c87c764f38f4dbda9d6ab2dda7f5036?sid=fcccbea6-cb74-483f-a950-1b260cda4171

Now, after @hkirat bhaiya's reply, I am going to make a new PR with these changes.

@SujithThirumalaisamy
Copy link
Contributor

check this out link: https://www.loom.com/share/5c87c764f38f4dbda9d6ab2dda7f5036?sid=fcccbea6-cb74-483f-a950-1b260cda4171

Now, after @hkirat bhaiya's reply, I am going to make a new PR with these changes.

This can be here. No worries

@SujithThirumalaisamy
Copy link
Contributor

Looks great to me. We can also get the code component insted of the editor in the submission form also. Is it possible?

@ArpitBlagan
Copy link
Author

We can do that, but I think an editor jsut like LeetCode would be better. This way, if a user wants to add comments or make other changes, they won't need to go back and update the code.

@SujithThirumalaisamy
Copy link
Contributor

Yeah that is a valid point. Then this works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants