Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility tables for specified graphs #438

Merged

Conversation

GabrielMajeri
Copy link
Contributor

What does it fix?

Renders the statistical data in a tabular format, visible only to screen readers.

Closes #425

How has it been tested?

This is how the tables look like if the is-sr-only class is removed from them:

image

image

image

image

@vercel
Copy link

vercel bot commented May 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/date-la-zi/8iMefMhty8CTgoqLD1UeSbxDC2Te
✅ Preview: https://date-la-zi-git-fork-gabrielmajeri-add-accessibility-68a831.vercel.app

@catileptic
Copy link
Member

Thank you for this PR, @GabrielMajeri! This is a great feature and I'm so happy to see it implemented.

@Utwo, does this looks good to you? : -)

@Utwo
Copy link
Member

Utwo commented May 31, 2021

Looks great! Thank you @GabrielMajeri ! 🔥

@catileptic catileptic merged commit 37946b1 into code4romania:develop May 31, 2021
@GabrielMajeri GabrielMajeri deleted the add-accessibility-tables branch May 31, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a11y tables for all graphs
3 participants