Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add a11y tables for all graphs #425 part 1 #431

Conversation

swoopstyle
Copy link

What does it fix?

Closes #XXX

How has it been tested?

@vercel
Copy link

vercel bot commented Apr 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/date-la-zi/2SQe8x3Nw1uy1ajhtvQiS9XzJe2v
✅ Preview: https://date-la-zi-git-fork-swoopstyle-add-a11y-tables-for-a-c363bc.vercel.app

@swoopstyle swoopstyle changed the title Add a11y tables for all graphs #425 part 1 WIP: Add a11y tables for all graphs #425 part 1 Apr 24, 2021
Copy link
Member

@catileptic catileptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not add tables, this modifies an existing table. Can you help me understand what the point of these changes is?

@swoopstyle
Copy link
Author

swoopstyle commented May 29, 2021

@catileptic I have tried to resolve the issue of accessibility for individuals that would like to access the page without a mouse first considering that was one of the requirements. I have not managed to get to all the other points as I have been slightly busy with several other projects ( nano technology degree, data science and mysql course and I have joined Techcelerator RO remotely as well), however I would like to continue continue working on this. If it s a matter of urgency please feel free to involve someone else as well.

@catileptic
Copy link
Member

Closing this PR since the functionality has already been implemented by #438

@catileptic catileptic closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants