Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend on cases/day graph #364

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

Utwo
Copy link
Member

@Utwo Utwo commented Aug 5, 2020

Closes #361

@vercel
Copy link

vercel bot commented Aug 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/date-la-zi/rmx4al9do
✅ Preview: https://date-la-zi-git-fork-utwo-fix-case-day-legend.code4romania.vercel.app

@web-sys1
Copy link

web-sys1 commented Aug 5, 2020

Sorry @catileptic, but the problem is far to be resolved.
screenshot-1596626342861

Also, got error message when I've opened DevTools > Console in Chrome browser:

TypeError: Cannot read property 'seriesName' of undefined
    at formatter (main.845387c9.chunk.js?__WB_REVISION__=eb503ea4e7511eb64dcc:1)
    at n._showTooltipContent (TooltipView.js:543)
    at n.<anonymous> (TooltipView.js:437)
    at util.js:426
    at n._showOrMove (TooltipView.js:355)
    at n._showAxisTooltip (TooltipView.js:433)
    at n._tryShow (TooltipView.js:330)
    at n.manuallyShowTip (TooltipView.js:229)
    at c (echarts.js:1039)
    at V.<anonymous> (echarts.js:1034)

@Utwo
Copy link
Member Author

Utwo commented Aug 5, 2020

Sorry @catileptic, but the problem is far to be resolved.
screenshot-1596626342861

Also, got error message when I've opened DevTools > Console in Chrome browser:

TypeError: Cannot read property 'seriesName' of undefined
    at formatter (main.845387c9.chunk.js?__WB_REVISION__=eb503ea4e7511eb64dcc:1)
    at n._showTooltipContent (TooltipView.js:543)
    at n.<anonymous> (TooltipView.js:437)
    at util.js:426
    at n._showOrMove (TooltipView.js:355)
    at n._showAxisTooltip (TooltipView.js:433)
    at n._tryShow (TooltipView.js:330)
    at n.manuallyShowTip (TooltipView.js:229)
    at c (echarts.js:1039)
    at V.<anonymous> (echarts.js:1034)

Hello, please test the following URL: https://date-la-zi-git-fork-utwo-fix-case-day-legend.code4romania.vercel.app/

@surdu
Copy link
Member

surdu commented Aug 5, 2020

@web-sys1 the fix is not published yet.

@web-sys1
Copy link

web-sys1 commented Aug 5, 2020

@surdu Worked well. It takes a while to be published on website.
screen1596632242838-anim

@web-sys1
Copy link

web-sys1 commented Aug 5, 2020

Also, I requested adding processed tests graph (see #349)

@Utwo Utwo deleted the fix-case-day-legend branch August 5, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph crashes if disabling one graph and then hover the graph
4 participants