Skip to content

Commit

Permalink
Fix validate_certs not used issue.
Browse files Browse the repository at this point in the history
Fix #27. Now a provided `validate_certs` parameter is used in api
connection.
  • Loading branch information
cmeissner committed Nov 12, 2020
1 parent 5dbf69b commit 55fc9a1
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ codeaffen.phpipam Release Notes
.. contents:: Topics


v1.1.1
======

Bugfixes
--------

- Fix `validate_certs` is not used for api connection (https://github.com/codeaffen/phpipam-ansible-modules/issues/27)

v1.1.0
======

Expand Down
7 changes: 7 additions & 0 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,10 @@ releases:
fragments:
- missing_validate_certs_parameter.yml
release_date: '2020-11-12'
1.1.1:
changes:
bugfixes:
- Fix `validate_certs` is not used for api connection (https://github.com/codeaffen/phpipam-ansible-modules/issues/27)
fragments:
- fix_validate_certs_not_used.yml
release_date: '2020-11-12'
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: "phpipam"
description: Ansible Modules to manage phpIPAM installations
authors:
- "Christian Meißner <[email protected]>"
version: "1.1.0"
version: "1.1.1"
license:
- "GPL-3.0-or-later"
tags:
Expand Down
4 changes: 2 additions & 2 deletions plugins/module_utils/phpipam_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def __init__(self, **kwargs):
self._phpipamapi_app_id = self.phpipam_params.get('app_id')
self._phpipamapi_username = self.phpipam_params.get('username')
self._phpipamapi_password = self.phpipam_params.get('password')
self._phpipamapi_ssl_verify = self.phpipam_params.get('ssl_verify', True)
self._phpipamapi_validate_certs = self.phpipam_params.get('validate_certs', True)
self._phpipamapi_path = kwargs.get('phpipam_path')
self._phpipamapi_params = kwargs.get('phpipam_params')

Expand Down Expand Up @@ -116,7 +116,7 @@ def connect(self):
app_id=self._phpipamapi_app_id,
username=self._phpipamapi_username,
password=self._phpipamapi_password,
ssl_verify=self._phpipamapi_ssl_verify,
ssl_verify=self._phpipamapi_validate_certs,
user_agent="phpipam-ansible-modules",
)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_playbooks/tasks/section.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
show_vrf: "{{ section_show_vrf | default(omit) }}"
show_supernets_only: "{{ section_show_supernets_only | default(omit) }}"
dns_resolver: "{{ section_dns_resolver | default(omit) }}"
validate_certs: "{{ section_validate_certs | default(omit) }}"
validate_certs: "{{ section_validate_certs | default('no') }}"
state: "{{ section_state | default('present') }}"

0 comments on commit 55fc9a1

Please sign in to comment.