Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut off phpipam api calls from phpipam_utils.py to make it more plugins available. #72

Open
cmeissner opened this issue Jan 6, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cmeissner
Copy link
Member

Is your feature request related to a problem? Please describe.
In the early beginning of this project we decided to put all api calls inside classes where all modules derive from.
This was fine until we want to start developing plugins such as lookup and inventory plugins. This plugin classes can not be derived from PhpipamAnsibleModule or PhpipamEntityAnsibleModule.

Describe the solution you'd like
Now it is time to create a module which provides a phpipam related classes and methods in a way we can use it for all kinds of plugins.
After creating such a module we can use it for all our plugins and modules. Another benifit will be that we can hide handling of strange different api calls from the user but we provide a common way. See it like a layer of abstraction.

@cmeissner cmeissner added the enhancement New feature or request label Jan 6, 2022
@cmeissner cmeissner self-assigned this Jan 6, 2022
@cmeissner cmeissner linked a pull request Jan 6, 2022 that will close this issue
@cmeissner cmeissner added this to the v2 milestone Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 5, 2023
@cmeissner cmeissner removed the Stale label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant