Refactoring_api_interactions #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we need interaction with phpipam api not only in modules but also in plugins like lookup and inventory plugins we decided to cut all the common stuff out into a seperate class. This class should provide all methods to interact with the phpipam api in one place. With this first commit we start to adapt all existing methods from `phpipam_helper` module in `_phpypam` module. Next we put comments into the source module to made clear what to achieve with the new class and its methods. This commit is non inversive.
We now use our new `codeaffen/phpipam-action` to setup the phpipam instance.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Closed as work is staled. Maybe a new one will be opened anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we need interaction with phpipam api not only in modules but also in plugins like lookup and inventory plugins we decided to cut all the common stuff out into a seperate class. This class should provide all methods to interact with the phpipam api in one place.