Skip to content

Commit

Permalink
Standardize sing up button language and use translation strings
Browse files Browse the repository at this point in the history
  • Loading branch information
matyikriszta committed Aug 12, 2024
1 parent 4d6bde8 commit ae6cab5
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion app/views/chapter/show.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
- if logged_in?
= render partial: 'subscriptions'
- else
= link_to 'Join our community', new_member_path, class: 'btn btn-primary'
= link_to t('members.sign_up'), new_member_path, class: 'btn btn-primary'

.container.py-4.py-lg-5
.row
Expand Down
2 changes: 1 addition & 1 deletion app/views/dashboard/show.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
.container.d-flex
.col-md-5.offset-md-1.p-3.text
%p.lead.mb-0= raw t('homepage.intro')
= link_to ('Join our community'), new_member_path, class: 'btn btn-primary btn-lg mt-4'
= link_to t('members.sign_up'), new_member_path, class: 'btn btn-primary btn-lg mt-4'

.py-4.py-lg-5.bg-light
.container
Expand Down
2 changes: 1 addition & 1 deletion app/views/events/_event_actions.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
= link_to event_coach_rsvp_path(@event), class: 'btn btn-primary' do
= t('events.attend_as_coach')
- else
= link_to 'Sign up', new_member_path, class: 'btn btn-primary me-2'
= link_to t('members.sign_up'), new_member_path, class: 'btn btn-primary me-2'
= link_to 'Log in', login_path, class: 'btn btn-primary'
- else
%p.badge.bg-primary= t('events.not_open_for_rsvp')
2 changes: 1 addition & 1 deletion app/views/meetings/_meeting_actions.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@
%strong This event is not open for RSVP.

- else
= link_to 'Sign up', new_member_path, class: 'btn btn-primary'
= link_to t('members.sign_up'), new_member_path, class: 'btn btn-primary'
= link_to 'Log in', login_path, class: 'btn btn-primary'
2 changes: 1 addition & 1 deletion app/views/workshops/_actions.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@

- elsif not logged_in?
%div
= link_to 'Sign up', new_member_path, class: 'btn btn-primary'
= link_to t('members.sign_up'), new_member_path, class: 'btn btn-primary'
= link_to 'Log in', login_path, class: 'btn btn-primary'
4 changes: 2 additions & 2 deletions spec/features/view_event_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@

scenario 'a student cannot RSVP if they are not logged in' do
expect(page).to have_link('Log in')
expect(page).to have_link('Sign up')
expect(page).to have_link('Join our community')
expect(page).to_not have_link('Attend as a student')
end

scenario 'a coach cannot RSVP if they are not logged in' do
expect(page).to have_link('Log in')
expect(page).to have_link('Sign up')
expect(page).to have_link('Join our community')
expect(page).to_not have_link('Attend as a coach')
end
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
RSpec.shared_examples 'viewing workshop actions' do
scenario 'signing up or signing in' do
expect(page).to have_content('Sign up')
expect(page).to have_content('Join our community')
expect(page).to have_content('Log in')
end
end

0 comments on commit ae6cab5

Please sign in to comment.