Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump to eslint9+ and remove eslint-config-google #1591

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (b9fd7d1) to head (a3de2a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
+ Coverage   91.94%   93.13%   +1.19%     
==========================================
  Files           5        5              
  Lines         335      335              
  Branches       78       78              
==========================================
+ Hits          308      312       +4     
+ Misses         27       23       -4     
Flag Coverage Δ
demo 93.13% <ø> (+1.19%) ⬆️
macos-latest 93.13% <ø> (+1.19%) ⬆️
script 93.13% <ø> (+1.19%) ⬆️
ubuntu-latest 93.13% <ø> (+1.19%) ⬆️
version 93.13% <ø> (+1.19%) ⬆️
windows-latest 93.13% <ø> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrockhu-codecov thomasrockhu-codecov merged commit ef609d6 into main Oct 3, 2024
15 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/bump-eslint-to-v9 branch October 3, 2024 15:47
@lishaduck
Copy link

lishaduck commented Oct 23, 2024

Was working on #1524 and noticed that all the formatting rules were gone. Was that intentional, or did you forget to migrate to eslint-stylistic?
Also, you don't need flatcompat, spreading imports should be fine for your usecase.
Lastly, typescript-eslint published a typescript-eslint that's the preferred import nowadays.

@thomasrockhu-codecov
Copy link
Contributor Author

@lishaduck I wish I had known this so much earlier, thanks for all the info!

That said, we are moving to a bash script in the next release and thus the js/ts stuff will be all going away. Let me know if that makes sense.

@lishaduck
Copy link

lishaduck commented Oct 24, 2024

We are moving to a bash script in the next release and thus the js/ts stuff will be all going away.

Yay! Dropping Node is always good 🙃 I assume it's to speed it up more, but may I request that you fix #770/#1582 while you're at it b/c (if quoted right) it should just expand with native bash globs, right?

@thomasrockhu-codecov
Copy link
Contributor Author

@lishaduck ahhh, yes I'll add that to the priority list post release next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants