Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle analysis: [GQL] Add asset routes to BundleAsset type #1010

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Nov 29, 2024

Follows codecov/shared#443

Now we retrieve the routes from AssetReport and exposes in GQL via BundleAsset.routes

Closes: codecov/engineering-team#2934

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

github-actions bot commented Nov 29, 2024

This PR includes changes to shared. Please review them here: codecov/shared@c481846...00e90bb

@@ -20,7 +20,7 @@ factory-boy
fakeredis
freezegun
https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem
https://github.com/codecov/shared/archive/c481846ba657aee3fc15a613a0fd2c18ac1eabd2.tar.gz#egg=shared
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be updated once the shared PR is merged into main
codecov/shared#443

@JerrySentry JerrySentry marked this pull request as ready for review November 29, 2024 19:39
@JerrySentry JerrySentry requested a review from a team as a code owner November 29, 2024 19:39
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Nov 29, 2024

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2692 6 2686 6
View the top 3 failed tests by shortest run time
graphql_api/tests/test_commit.py::TestCommit::test_bundle_analysis_report_assets_paginated_first_after_non_existing_cursor
Stack Traces | 0.504s run time
self = <graphql_api.tests.test_commit.TestCommit testMethod=test_bundle_analysis_report_assets_paginated_first_after_non_existing_cursor>
get_storage_service = <MagicMock name='get_appropriate_storage_service' id='140421343645760'>

    @patch("graphql_api.dataloader.bundle_analysis.get_appropriate_storage_service")
    def test_bundle_analysis_report_assets_paginated_first_after_non_existing_cursor(
        self, get_storage_service
    ):
        storage = MemoryStorageService({})
        get_storage_service.return_value = storage
    
        head_commit_report = CommitReportFactory(
            commit=self.commit, report_type=CommitReport.ReportType.BUNDLE_ANALYSIS
        )
    
        with open("..../tests/samples/head_bundle_report.sqlite", "rb") as f:
            storage_path = StoragePaths.bundle_report.path(
                repo_key=ArchiveService.get_archive_hash(self.repo),
                report_key=head_commit_report.external_id,
            )
            storage.write_file(get_bucket_name(), storage_path, f)
    
        query = """
            query FetchCommit(
                $org: String!,
                $repo: String!,
                $commit: String!,
                $ordering: AssetOrdering,
                $orderingDirection: OrderingDirection
            ) {
                owner(username: $org) {
                    repository(name: $repo) {
                        ... on Repository {
                            commit(id: $commit) {
                                bundleAnalysis {
                                    bundleAnalysisReport {
                                        __typename
                                        ... on BundleAnalysisReport {
                                            bundle(name: "b1") {
                                                assetsPaginated (
                                                    ordering: $ordering,
                                                    orderingDirection: $orderingDirection,
                                                    first: 2,
                                                    after: "notanumber",
                                                ){
                                                    totalCount
                                                    edges {
                                                        cursor
                                                        node {
                                                            normalizedName
                                                        }
                                                    }
                                                    pageInfo {
                                                        hasNextPage
                                                        hasPreviousPage
                                                        startCursor
                                                        endCursor
                                                    }
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        """
    
        variables = {
            "org": self.org.username,
            "repo": self.repo.name,
            "commit": self.commit.commitid,
            "ordering": "NAME",
            "orderingDirection": "ASC",
        }
        data = self.gql_request(query, variables=variables)
        commit = data["owner"]["repository"]["commit"]
    
>       assert commit["bundleAnalysis"]["bundleAnalysisReport"] == {
            "__typename": "BundleAnalysisReport",
            "bundle": {
                "assetsPaginated": {
                    "totalCount": 5,
                    "edges": [
                        {
                            "cursor": "3",
                            "node": {
                                "normalizedName": "assets/LazyComponent-*.js",
                            },
                        },
                        {
                            "cursor": "5",
                            "node": {
                                "normalizedName": "assets/index-*.js",
                            },
                        },
                    ],
                    "pageInfo": {
                        "hasNextPage": True,
                        "hasPreviousPage": False,
                        "startCursor": "3",
                        "endCursor": "5",
                    },
                }
            },
        }
E       AssertionError: assert {'__typename'...nated': None}} == {'__typename'...alCount': 5}}}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'bundle': {'assetsPaginated': None}} != {'bundle': {'assetsPaginated': {'edges': [{'cursor': '3', 'node': {'normalizedName': 'assets/LazyComponent-*.js'}}, {'..., 'pageInfo': {'endCursor': '5', 'hasNextPage': True, 'hasPreviousPage': False, 'startCursor': '3'}, 'totalCount': 5}}}
E         Use -v to get more diff

graphql_api/tests/test_commit.py:1529: AssertionError
graphql_api/tests/test_commit.py::TestCommit::test_bundle_analysis_report_assets_paginated_last_before
Stack Traces | 0.515s run time
self = <graphql_api.tests.test_commit.TestCommit testMethod=test_bundle_analysis_report_assets_paginated_last_before>
get_storage_service = <MagicMock name='get_appropriate_storage_service' id='140409963600960'>

    @patch("graphql_api.dataloader.bundle_analysis.get_appropriate_storage_service")
    def test_bundle_analysis_report_assets_paginated_last_before(
        self, get_storage_service
    ):
        storage = MemoryStorageService({})
        get_storage_service.return_value = storage
    
        head_commit_report = CommitReportFactory(
            commit=self.commit, report_type=CommitReport.ReportType.BUNDLE_ANALYSIS
        )
    
        with open("..../tests/samples/head_bundle_report.sqlite", "rb") as f:
            storage_path = StoragePaths.bundle_report.path(
                repo_key=ArchiveService.get_archive_hash(self.repo),
                report_key=head_commit_report.external_id,
            )
            storage.write_file(get_bucket_name(), storage_path, f)
    
        query = """
            query FetchCommit(
                $org: String!,
                $repo: String!,
                $commit: String!,
                $ordering: AssetOrdering,
                $orderingDirection: OrderingDirection
            ) {
                owner(username: $org) {
                    repository(name: $repo) {
                        ... on Repository {
                            commit(id: $commit) {
                                bundleAnalysis {
                                    bundleAnalysisReport {
                                        __typename
                                        ... on BundleAnalysisReport {
                                            bundle(name: "b1") {
                                                assetsPaginated (
                                                    ordering: $ordering,
                                                    orderingDirection: $orderingDirection,
                                                    last: 2,
                                                    before: "1",
                                                ){
                                                    totalCount
                                                    edges {
                                                        cursor
                                                        node {
                                                            normalizedName
                                                        }
                                                    }
                                                    pageInfo {
                                                        hasNextPage
                                                        hasPreviousPage
                                                        startCursor
                                                        endCursor
                                                    }
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        """
    
        variables = {
            "org": self.org.username,
            "repo": self.repo.name,
            "commit": self.commit.commitid,
            "ordering": "NAME",
            "orderingDirection": "ASC",
        }
        data = self.gql_request(query, variables=variables)
        commit = data["owner"]["repository"]["commit"]
    
>       assert commit["bundleAnalysis"]["bundleAnalysisReport"] == {
            "__typename": "BundleAnalysisReport",
            "bundle": {
                "assetsPaginated": {
                    "totalCount": 5,
                    "edges": [
                        {
                            "cursor": "4",
                            "node": {
                                "normalizedName": "assets/index-*.js",
                            },
                        },
                        {
                            "cursor": "2",
                            "node": {
                                "normalizedName": "assets/index-*.css",
                            },
                        },
                    ],
                    "pageInfo": {
                        "hasNextPage": False,
                        "hasPreviousPage": True,
                        "startCursor": "4",
                        "endCursor": "2",
                    },
                }
            },
        }
E       AssertionError: assert {'__typename'...nated': None}} == {'__typename'...alCount': 5}}}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'bundle': {'assetsPaginated': None}} != {'bundle': {'assetsPaginated': {'edges': [{'cursor': '4', 'node': {'normalizedName': 'assets/index-*.js'}}, {'cursor':..., 'pageInfo': {'endCursor': '2', 'hasNextPage': False, 'hasPreviousPage': True, 'startCursor': '4'}, 'totalCount': 5}}}
E         Use -v to get more diff

graphql_api/tests/test_commit.py:1634: AssertionError
graphql_api/tests/test_commit.py::TestCommit::test_bundle_analysis_report_assets_paginated_last_before_non_existing_cursor
Stack Traces | 0.518s run time
self = <graphql_api.tests.test_commit.TestCommit testMethod=test_bundle_analysis_report_assets_paginated_last_before_non_existing_cursor>
get_storage_service = <MagicMock name='get_appropriate_storage_service' id='140422005709024'>

    @patch("graphql_api.dataloader.bundle_analysis.get_appropriate_storage_service")
    def test_bundle_analysis_report_assets_paginated_last_before_non_existing_cursor(
        self, get_storage_service
    ):
        storage = MemoryStorageService({})
        get_storage_service.return_value = storage
    
        head_commit_report = CommitReportFactory(
            commit=self.commit, report_type=CommitReport.ReportType.BUNDLE_ANALYSIS
        )
    
        with open("..../tests/samples/head_bundle_report.sqlite", "rb") as f:
            storage_path = StoragePaths.bundle_report.path(
                repo_key=ArchiveService.get_archive_hash(self.repo),
                report_key=head_commit_report.external_id,
            )
            storage.write_file(get_bucket_name(), storage_path, f)
    
        query = """
            query FetchCommit(
                $org: String!,
                $repo: String!,
                $commit: String!,
                $ordering: AssetOrdering,
                $orderingDirection: OrderingDirection
            ) {
                owner(username: $org) {
                    repository(name: $repo) {
                        ... on Repository {
                            commit(id: $commit) {
                                bundleAnalysis {
                                    bundleAnalysisReport {
                                        __typename
                                        ... on BundleAnalysisReport {
                                            bundle(name: "b1") {
                                                assetsPaginated (
                                                    ordering: $ordering,
                                                    orderingDirection: $orderingDirection,
                                                    last: 2,
                                                    before: "99999",
                                                ){
                                                    totalCount
                                                    edges {
                                                        cursor
                                                        node {
                                                            normalizedName
                                                        }
                                                    }
                                                    pageInfo {
                                                        hasNextPage
                                                        hasPreviousPage
                                                        startCursor
                                                        endCursor
                                                    }
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        """
    
        variables = {
            "org": self.org.username,
            "repo": self.repo.name,
            "commit": self.commit.commitid,
            "ordering": "NAME",
            "orderingDirection": "ASC",
        }
        data = self.gql_request(query, variables=variables)
        commit = data["owner"]["repository"]["commit"]
    
>       assert commit["bundleAnalysis"]["bundleAnalysisReport"] == {
            "__typename": "BundleAnalysisReport",
            "bundle": {
                "assetsPaginated": {
                    "totalCount": 5,
                    "edges": [
                        {
                            "cursor": "2",
                            "node": {
                                "normalizedName": "assets/index-*.css",
                            },
                        },
                        {
                            "cursor": "1",
                            "node": {
                                "normalizedName": "assets/react-*.svg",
                            },
                        },
                    ],
                    "pageInfo": {
                        "hasNextPage": False,
                        "hasPreviousPage": True,
                        "startCursor": "2",
                        "endCursor": "1",
                    },
                }
            },
        }
E       AssertionError: assert {'__typename'...nated': None}} == {'__typename'...alCount': 5}}}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'bundle': {'assetsPaginated': None}} != {'bundle': {'assetsPaginated': {'edges': [{'cursor': '2', 'node': {'normalizedName': 'assets/index-*.css'}}, {'cursor'..., 'pageInfo': {'endCursor': '1', 'hasNextPage': False, 'hasPreviousPage': True, 'startCursor': '2'}, 'totalCount': 5}}}
E         Use -v to get more diff

graphql_api/tests/test_commit.py:1739: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2692 6 2686 6
View the top 3 failed tests by shortest run time
graphql_api/tests/test_commit.py::TestCommit::test_bundle_analysis_report_assets_paginated_first_after_non_existing_cursor
Stack Traces | 0.504s run time
self = &lt;graphql_api.tests.test_commit.TestCommit testMethod=test_bundle_analysis_report_assets_paginated_first_after_non_existing_cursor&gt;
get_storage_service = &lt;MagicMock name='get_appropriate_storage_service' id='140421343645760'&gt;

    @patch("graphql_api.dataloader.bundle_analysis.get_appropriate_storage_service")
    def test_bundle_analysis_report_assets_paginated_first_after_non_existing_cursor(
        self, get_storage_service
    ):
        storage = MemoryStorageService({})
        get_storage_service.return_value = storage
    
        head_commit_report = CommitReportFactory(
            commit=self.commit, report_type=CommitReport.ReportType.BUNDLE_ANALYSIS
        )
    
        with open("..../tests/samples/head_bundle_report.sqlite", "rb") as f:
            storage_path = StoragePaths.bundle_report.path(
                repo_key=ArchiveService.get_archive_hash(self.repo),
                report_key=head_commit_report.external_id,
            )
            storage.write_file(get_bucket_name(), storage_path, f)
    
        query = """
            query FetchCommit(
                $org: String!,
                $repo: String!,
                $commit: String!,
                $ordering: AssetOrdering,
                $orderingDirection: OrderingDirection
            ) {
                owner(username: $org) {
                    repository(name: $repo) {
                        ... on Repository {
                            commit(id: $commit) {
                                bundleAnalysis {
                                    bundleAnalysisReport {
                                        __typename
                                        ... on BundleAnalysisReport {
                                            bundle(name: "b1") {
                                                assetsPaginated (
                                                    ordering: $ordering,
                                                    orderingDirection: $orderingDirection,
                                                    first: 2,
                                                    after: "notanumber",
                                                ){
                                                    totalCount
                                                    edges {
                                                        cursor
                                                        node {
                                                            normalizedName
                                                        }
                                                    }
                                                    pageInfo {
                                                        hasNextPage
                                                        hasPreviousPage
                                                        startCursor
                                                        endCursor
                                                    }
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        """
    
        variables = {
            "org": self.org.username,
            "repo": self.repo.name,
            "commit": self.commit.commitid,
            "ordering": "NAME",
            "orderingDirection": "ASC",
        }
        data = self.gql_request(query, variables=variables)
        commit = data["owner"]["repository"]["commit"]
    
&gt;       assert commit["bundleAnalysis"]["bundleAnalysisReport"] == {
            "__typename": "BundleAnalysisReport",
            "bundle": {
                "assetsPaginated": {
                    "totalCount": 5,
                    "edges": [
                        {
                            "cursor": "3",
                            "node": {
                                "normalizedName": "assets/LazyComponent-*.js",
                            },
                        },
                        {
                            "cursor": "5",
                            "node": {
                                "normalizedName": "assets/index-*.js",
                            },
                        },
                    ],
                    "pageInfo": {
                        "hasNextPage": True,
                        "hasPreviousPage": False,
                        "startCursor": "3",
                        "endCursor": "5",
                    },
                }
            },
        }
E       AssertionError: assert {'__typename'...nated': None}} == {'__typename'...alCount': 5}}}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'bundle': {'assetsPaginated': None}} != {'bundle': {'assetsPaginated': {'edges': [{'cursor': '3', 'node': {'normalizedName': 'assets/LazyComponent-*.js'}}, {'..., 'pageInfo': {'endCursor': '5', 'hasNextPage': True, 'hasPreviousPage': False, 'startCursor': '3'}, 'totalCount': 5}}}
E         Use -v to get more diff

graphql_api/tests/test_commit.py:1529: AssertionError
graphql_api/tests/test_commit.py::TestCommit::test_bundle_analysis_report_assets_paginated_last_before
Stack Traces | 0.515s run time
self = &lt;graphql_api.tests.test_commit.TestCommit testMethod=test_bundle_analysis_report_assets_paginated_last_before&gt;
get_storage_service = &lt;MagicMock name='get_appropriate_storage_service' id='140409963600960'&gt;

    @patch("graphql_api.dataloader.bundle_analysis.get_appropriate_storage_service")
    def test_bundle_analysis_report_assets_paginated_last_before(
        self, get_storage_service
    ):
        storage = MemoryStorageService({})
        get_storage_service.return_value = storage
    
        head_commit_report = CommitReportFactory(
            commit=self.commit, report_type=CommitReport.ReportType.BUNDLE_ANALYSIS
        )
    
        with open("..../tests/samples/head_bundle_report.sqlite", "rb") as f:
            storage_path = StoragePaths.bundle_report.path(
                repo_key=ArchiveService.get_archive_hash(self.repo),
                report_key=head_commit_report.external_id,
            )
            storage.write_file(get_bucket_name(), storage_path, f)
    
        query = """
            query FetchCommit(
                $org: String!,
                $repo: String!,
                $commit: String!,
                $ordering: AssetOrdering,
                $orderingDirection: OrderingDirection
            ) {
                owner(username: $org) {
                    repository(name: $repo) {
                        ... on Repository {
                            commit(id: $commit) {
                                bundleAnalysis {
                                    bundleAnalysisReport {
                                        __typename
                                        ... on BundleAnalysisReport {
                                            bundle(name: "b1") {
                                                assetsPaginated (
                                                    ordering: $ordering,
                                                    orderingDirection: $orderingDirection,
                                                    last: 2,
                                                    before: "1",
                                                ){
                                                    totalCount
                                                    edges {
                                                        cursor
                                                        node {
                                                            normalizedName
                                                        }
                                                    }
                                                    pageInfo {
                                                        hasNextPage
                                                        hasPreviousPage
                                                        startCursor
                                                        endCursor
                                                    }
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        """
    
        variables = {
            "org": self.org.username,
            "repo": self.repo.name,
            "commit": self.commit.commitid,
            "ordering": "NAME",
            "orderingDirection": "ASC",
        }
        data = self.gql_request(query, variables=variables)
        commit = data["owner"]["repository"]["commit"]
    
&gt;       assert commit["bundleAnalysis"]["bundleAnalysisReport"] == {
            "__typename": "BundleAnalysisReport",
            "bundle": {
                "assetsPaginated": {
                    "totalCount": 5,
                    "edges": [
                        {
                            "cursor": "4",
                            "node": {
                                "normalizedName": "assets/index-*.js",
                            },
                        },
                        {
                            "cursor": "2",
                            "node": {
                                "normalizedName": "assets/index-*.css",
                            },
                        },
                    ],
                    "pageInfo": {
                        "hasNextPage": False,
                        "hasPreviousPage": True,
                        "startCursor": "4",
                        "endCursor": "2",
                    },
                }
            },
        }
E       AssertionError: assert {'__typename'...nated': None}} == {'__typename'...alCount': 5}}}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'bundle': {'assetsPaginated': None}} != {'bundle': {'assetsPaginated': {'edges': [{'cursor': '4', 'node': {'normalizedName': 'assets/index-*.js'}}, {'cursor':..., 'pageInfo': {'endCursor': '2', 'hasNextPage': False, 'hasPreviousPage': True, 'startCursor': '4'}, 'totalCount': 5}}}
E         Use -v to get more diff

graphql_api/tests/test_commit.py:1634: AssertionError
graphql_api/tests/test_commit.py::TestCommit::test_bundle_analysis_report_assets_paginated_last_before_non_existing_cursor
Stack Traces | 0.518s run time
self = &lt;graphql_api.tests.test_commit.TestCommit testMethod=test_bundle_analysis_report_assets_paginated_last_before_non_existing_cursor&gt;
get_storage_service = &lt;MagicMock name='get_appropriate_storage_service' id='140422005709024'&gt;

    @patch("graphql_api.dataloader.bundle_analysis.get_appropriate_storage_service")
    def test_bundle_analysis_report_assets_paginated_last_before_non_existing_cursor(
        self, get_storage_service
    ):
        storage = MemoryStorageService({})
        get_storage_service.return_value = storage
    
        head_commit_report = CommitReportFactory(
            commit=self.commit, report_type=CommitReport.ReportType.BUNDLE_ANALYSIS
        )
    
        with open("..../tests/samples/head_bundle_report.sqlite", "rb") as f:
            storage_path = StoragePaths.bundle_report.path(
                repo_key=ArchiveService.get_archive_hash(self.repo),
                report_key=head_commit_report.external_id,
            )
            storage.write_file(get_bucket_name(), storage_path, f)
    
        query = """
            query FetchCommit(
                $org: String!,
                $repo: String!,
                $commit: String!,
                $ordering: AssetOrdering,
                $orderingDirection: OrderingDirection
            ) {
                owner(username: $org) {
                    repository(name: $repo) {
                        ... on Repository {
                            commit(id: $commit) {
                                bundleAnalysis {
                                    bundleAnalysisReport {
                                        __typename
                                        ... on BundleAnalysisReport {
                                            bundle(name: "b1") {
                                                assetsPaginated (
                                                    ordering: $ordering,
                                                    orderingDirection: $orderingDirection,
                                                    last: 2,
                                                    before: "99999",
                                                ){
                                                    totalCount
                                                    edges {
                                                        cursor
                                                        node {
                                                            normalizedName
                                                        }
                                                    }
                                                    pageInfo {
                                                        hasNextPage
                                                        hasPreviousPage
                                                        startCursor
                                                        endCursor
                                                    }
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        """
    
        variables = {
            "org": self.org.username,
            "repo": self.repo.name,
            "commit": self.commit.commitid,
            "ordering": "NAME",
            "orderingDirection": "ASC",
        }
        data = self.gql_request(query, variables=variables)
        commit = data["owner"]["repository"]["commit"]
    
&gt;       assert commit["bundleAnalysis"]["bundleAnalysisReport"] == {
            "__typename": "BundleAnalysisReport",
            "bundle": {
                "assetsPaginated": {
                    "totalCount": 5,
                    "edges": [
                        {
                            "cursor": "2",
                            "node": {
                                "normalizedName": "assets/index-*.css",
                            },
                        },
                        {
                            "cursor": "1",
                            "node": {
                                "normalizedName": "assets/react-*.svg",
                            },
                        },
                    ],
                    "pageInfo": {
                        "hasNextPage": False,
                        "hasPreviousPage": True,
                        "startCursor": "2",
                        "endCursor": "1",
                    },
                }
            },
        }
E       AssertionError: assert {'__typename'...nated': None}} == {'__typename'...alCount': 5}}}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'bundle': {'assetsPaginated': None}} != {'bundle': {'assetsPaginated': {'edges': [{'cursor': '2', 'node': {'normalizedName': 'assets/index-*.css'}}, {'cursor'..., 'pageInfo': {'endCursor': '1', 'hasNextPage': False, 'hasPreviousPage': True, 'startCursor': '2'}, 'totalCount': 5}}}
E         Use -v to get more diff

graphql_api/tests/test_commit.py:1739: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Contributor

github-actions bot commented Nov 29, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (022c44b) to head (6fd25af).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         828      828           
  Lines       19275    19278    +3     
=======================================
+ Hits        18516    18519    +3     
  Misses        759      759           
Flag Coverage Δ
unit 92.33% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

duration: Int!
bundler_name: String!
bundler_version: String!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any consumers of this api that need to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, nothing is using BundleReportInfo yet

@JerrySentry JerrySentry added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@JerrySentry JerrySentry added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@JerrySentry JerrySentry added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit fcee05d Dec 2, 2024
19 checks passed
@JerrySentry JerrySentry deleted the nov_29_ba_ui_routing branch December 2, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Update GraphQL to return routes
2 participants