Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict deactivated enterprise user access #910

Merged
merged 7 commits into from
Dec 31, 2024
Merged

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Oct 22, 2024

Restrict what deactivated Enterprise users can see when the environment has guest access turned off.

  • If guest access if off, deactivated users should not be able to see anything
  • If guest access is on, deactivated users should be able to see public repos, but not private repos

Closes codecov/engineering-team#1859

@suejung-sentry suejung-sentry requested a review from a team as a code owner October 22, 2024 07:12
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (db88c2d) to head (7b21302).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         828      828           
  Lines       19458    19461    +3     
=======================================
+ Hits        18684    18687    +3     
  Misses        774      774           
Flag Coverage Δ
unit 92.30% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@suejung-sentry suejung-sentry changed the title fix: Restrict deactiveated enterprise user access fix: Restrict deactivated enterprise user access Oct 22, 2024
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@suejung-sentry
Copy link
Contributor Author

Tested in local different scenarios with Enterprise + guest access. Also smoke-tested in staging that no impact on the cloud deployment. If guest access for the deployment is on, no change to the existing repo-level check of whether the user has permission to see the repo. If guest access is off, must be a planActivatedUser to do anything

Merged via the queue into main with commit 24784ce Dec 31, 2024
31 of 32 checks passed
@suejung-sentry suejung-sentry deleted the sshin/fix/1859 branch December 31, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enterprise deactivated user repo visibility
3 participants