-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Restrict deactivated enterprise user access #910
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #910 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 828 828
Lines 19458 19461 +3
=======================================
+ Hits 18684 18687 +3
Misses 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Tested in local different scenarios with Enterprise + guest access. Also smoke-tested in staging that no impact on the cloud deployment. If guest access for the deployment is on, no change to the existing repo-level check of whether the user has permission to see the repo. If guest access is off, must be a planActivatedUser to do anything |
Restrict what deactivated Enterprise users can see when the environment has guest access turned off.
Closes codecov/engineering-team#1859