Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Self-hosted] Auto-activate members doesn't work in latest/24.10.1 #554

Open
nikosatwork opened this issue Oct 23, 2024 · 12 comments · Fixed by codecov/codecov-api#996
Open
Assignees
Labels
bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints) Waiting for: Product Owner

Comments

@nikosatwork
Copy link

nikosatwork commented Oct 23, 2024

Describe the bug

  • Auto-activate members doesn't work in latest/24.10.1/24.11.1

Users will automatically be assigned a Codecov seat if they 1) author a pull request on a private repo, or 2) log in to a private repo and if there are seats available in the subscription.

Note: We have 2 active users of 500 available seats

Possibly related to #536 and #523

Environment (please complete the following information):

  • Browser Any
  • System: local machine
  • Codecov Version: 24.10.1, 24.11.1

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'User Settings'
  2. Set 'Activation Status' to false / uncheck
  3. Go to a private repository
  4. Get "Unauthorized. Activation is required to view this repo, please click here to activate your account."

Expected behavior

Activate the seat and land on a working repo page

Screenshots

Image

Image

Additional context

This is urgent as we have been trying to resolve this "mutating" issue since #523

Thank you 🙏

@covecod covecod bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Oct 23, 2024
@nikosatwork
Copy link
Author

The above workflow is true if guest_access: true

If guest_access: false then we can't even login at codecov home page as it keeps looping to itself

Will start downgrading the codecov version to try to find the regression

@nikosatwork
Copy link
Author

nikosatwork commented Oct 23, 2024

  • I think it is related to adding license logging back to startup perhaps

  • Downgraded to v24.8.1 and get the All Seats Taken even from seat 1, so that must have been broken before v24.7.1 I assume - Both with guest_access: true and with guest_access: false

  • Downgraded to v24.6.1/12 and still getting the All Seats Taken issue - Both with guest_access: true and with guest_access: false

@drazisil-codecov drazisil-codecov added bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints) labels Oct 24, 2024
@eliatcodecov
Copy link
Contributor

Likely related to #536 and this stems from issues with guest access breaking auto activate. Assigning to @RulaKhaled as this ticket and #536 likely share the same root cause.

@nikosatwork
Copy link
Author

I wanted to add that when a new user signs in with 'Login via GitHub Enterprise', they do not get their seat auto-activated either.

@nikosatwork
Copy link
Author

Hi team. Is there an update on this issue? Thank you 🙏

cc @drazisil-codecov @eliatcodecov @RulaKhaled

@RulaKhaled
Copy link

Hey @nikosatwork, I've divided this work into two key tasks:

  • Ensuring that we deliver more meaningful and precise error messages. PR can be found here feat: Handle self hosted activation statuses  gazebo#3523
  • Conducting a thorough investigation into auto-activation. This may take additional time, I’ll ensure to keep you informed on the progress

@RulaKhaled
Copy link

@nikosatwork Quick update: This PR should fix auto-activation. Once both PRs are merged, I'll check in with you to confirm it works as expected

@nikosatwork
Copy link
Author

Awesome! ❤

@RulaKhaled
Copy link

Hi again! You'll see all the new changes with the upcoming release. I'll mark them as merged until you confirm that everything works as expected after the release

@nikosatwork
Copy link
Author

Hi @RulaKhaled. I tested with 'rolling' images and it is looking good. Do you know when there will be a new 24.12.1 release out?

@RulaKhaled
Copy link

@nikosatwork It should be released today unless there is an unexpected roadblock

@nikosatwork
Copy link
Author

Thank you @RulaKhaled. I think we are blocked from updating because of #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints) Waiting for: Product Owner
Projects
Status: Waiting for: Product Owner
Development

Successfully merging a pull request may close this issue.

4 participants