-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle self hosted activation statuses #3523
Conversation
Bundle ReportChanges will increase total bundle size by 5.28kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 5.28kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3523 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 808 +2
Lines 14369 14414 +45
Branches 4077 4099 +22
==========================================
+ Hits 14216 14260 +44
- Misses 146 147 +1
Partials 7 7
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3523 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 808 +2
Lines 14369 14414 +45
Branches 4077 4099 +22
==========================================
+ Hits 14216 14260 +44
- Misses 146 147 +1
Partials 7 7
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3523 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 808 +2
Lines 14369 14414 +45
Branches 4084 4099 +15
==========================================
+ Hits 14216 14260 +44
- Misses 146 147 +1
Partials 7 7
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚨 Try these New Features:
|
|
||
function SeatsLimitReached() { | ||
return ( | ||
<div className="flex flex-col items-center justify-center gap-8 bg-ds-gray-primary pb-28 pt-12 text-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pull this into a variable? It's pretty long but identical to line 33 so it would be easier to know at a glance that the two components look the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 1 nit change to possibly incorporate
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3523 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 808 +2
Lines 14369 14414 +45
Branches 4084 4106 +22
==========================================
+ Hits 14216 14260 +44
- Misses 146 147 +1
Partials 7 7
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Description
In onboarding page: (Current user is not activated) => Banner
In the coverage page: (Current user is not activated) => Alert
Link to Sample Entry
Issue: #554
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.