Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle self hosted activation statuses #3523

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

In onboarding page: (Current user is not activated) => Banner

  • User has seats left:
    • User is admin, link to members page (access)
Screenshot 2024-11-20 at 11 48 58 AM
  • User is not an admin, contact admin
Screenshot 2024-11-20 at 11 48 34 AM
  • User has reached seats limit, contact sales
Screenshot 2024-11-21 at 1 04 55 PM

In the coverage page: (Current user is not activated) => Alert

  • User has seats left:
    • User is admin, link to members page (access)
Screenshot 2024-11-20 at 11 43 35 AM
  • User is not an admin, contact admin
Screenshot 2024-11-20 at 11 43 26 AM
  • User has reached seats limit, contact sales
Screenshot 2024-11-21 at 1 24 31 PM

Link to Sample Entry

Issue: #554

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Nov 21, 2024

Bundle Report

Changes will increase total bundle size by 5.28kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.62MB 2.79kB (0.05%) ⬆️
gazebo-staging-system 5.57MB 2.49kB (0.04%) ⬆️

Copy link

codecov bot commented Nov 21, 2024

Bundle Report

Changes will increase total bundle size by 5.28kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.57MB 2.49kB (0.04%) ⬆️
gazebo-production-system-esm 5.62MB 2.79kB (0.05%) ⬆️

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (a492dcd) to head (dd6e8a5).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         806      808       +2     
  Lines       14369    14414      +45     
  Branches     4077     4099      +22     
==========================================
+ Hits        14216    14260      +44     
- Misses        146      147       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...geOnboarding/ActivationBanner/ActivationBanner.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (-0.01%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a492dcd...dd6e8a5. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         806      808       +2     
  Lines       14369    14414      +45     
  Branches     4077     4099      +22     
==========================================
+ Hits        14216    14260      +44     
- Misses        146      147       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...geOnboarding/ActivationBanner/ActivationBanner.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (-0.01%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a492dcd...dd6e8a5. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (a492dcd) to head (dd6e8a5).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         806      808       +2     
  Lines       14369    14414      +45     
  Branches     4084     4099      +15     
==========================================
+ Hits        14216    14260      +44     
- Misses        146      147       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...geOnboarding/ActivationBanner/ActivationBanner.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (-0.01%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a492dcd...dd6e8a5. Read the comment docs.


🚨 Try these New Features:

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 21, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
bdaf264 Thu, 21 Nov 2024 13:04:43 GMT Expired Expired
03a3324 Thu, 21 Nov 2024 13:15:53 GMT Expired Expired
dd6e8a5 Mon, 25 Nov 2024 17:12:21 GMT Cloud Enterprise

@RulaKhaled RulaKhaled marked this pull request as draft November 21, 2024 13:06
@RulaKhaled RulaKhaled marked this pull request as ready for review November 21, 2024 13:29
@RulaKhaled RulaKhaled changed the base branch from main to staging November 21, 2024 13:34
@RulaKhaled RulaKhaled changed the base branch from staging to main November 21, 2024 13:43

function SeatsLimitReached() {
return (
<div className="flex flex-col items-center justify-center gap-8 bg-ds-gray-primary pb-28 pt-12 text-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pull this into a variable? It's pretty long but identical to line 33 so it would be easier to know at a glance that the two components look the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing

Copy link
Contributor

@calvin-codecov calvin-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 nit change to possibly incorporate

@RulaKhaled RulaKhaled added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit cfffad4 Nov 25, 2024
59 of 62 checks passed
@RulaKhaled RulaKhaled deleted the fix-self-hosted-bug branch November 25, 2024 17:48
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (a492dcd) to head (dd6e8a5).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3523      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         806      808       +2     
  Lines       14369    14414      +45     
  Branches     4084     4106      +22     
==========================================
+ Hits        14216    14260      +44     
- Misses        146      147       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...geOnboarding/ActivationBanner/ActivationBanner.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (-0.01%) ⬇️
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a492dcd...dd6e8a5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants