dev: Clean up some unneccesary mocks to speed up gazebo tests (#3604)

codecov · Dec 20, 2024 · 6a6fd2c · 6a6fd2c
1 parent fdd77d4
commit 6a6fd2c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 46 deletions.
diff --git a/src/pages/DefaultOrgSelector/DefaultOrgSelector.test.jsx b/src/pages/DefaultOrgSelector/DefaultOrgSelector.test.jsx
@@ -159,6 +159,7 @@ const wrapper =
   )
 
 beforeAll(() => {
+  console.error = () => {}
   server.listen({
     onUnhandledRequest: 'warn',
   })
@@ -169,6 +170,7 @@ afterEach(() => {
 })
 afterAll(() => {
   server.close()
+  vi.resetAllMocks()
 })
 
 describe('DefaultOrgSelector', () => {
@@ -1296,7 +1298,7 @@ describe('DefaultOrgSelector', () => {
 
   describe('on fetch next page', () => {
     it('renders next page', async () => {
-      const { user, fetchNextPage } = setup({
+      const { fetchNextPage } = setup({
         useUserData: mockUserData,
         myOrganizationsData: {
           me: {
@@ -1318,12 +1320,6 @@ describe('DefaultOrgSelector', () => {
       render(<DefaultOrgSelector />, { wrapper: wrapper() })
       mocks.useIntersection.mockReturnValue({ isIntersecting: true })
 
-      const selectOrg = await screen.findByRole('button', {
-        name: 'Select an organization',
-      })
-
-      await user.click(selectOrg)
-
       await waitFor(() => expect(fetchNextPage).toHaveBeenCalled())
       await waitFor(() => expect(fetchNextPage).toHaveBeenCalledWith('MTI='))
     })

diff --git a/src/pages/RepoPage/CommitsTab/CommitsTab.test.jsx b/src/pages/RepoPage/CommitsTab/CommitsTab.test.jsx
@@ -333,16 +333,6 @@ describe('CommitsTab', () => {
     })
 
     describe('when select onLoadMore is triggered', () => {
-      beforeEach(() => {
-        mocks.useIntersection.mockReturnValue({
-          isIntersecting: true,
-        })
-      })
-
-      afterEach(() => {
-        vi.clearAllMocks()
-      })
-
       describe('when there is not a next page', () => {
         it('does not call fetchNextPage', async () => {
           const { user, fetchNextPage } = setup({ hasNextPage: false })
@@ -359,12 +349,12 @@ describe('CommitsTab', () => {
 
       describe('when there is a next page', () => {
         it('calls fetchNextPage', async () => {
-          const { fetchNextPage, user } = setup({ hasNextPage: true })
+          const { fetchNextPage } = setup({ hasNextPage: true })
+          mocks.useIntersection.mockReturnValue({
+            isIntersecting: true,
+          })
           render(<CommitsTab />, { wrapper })
 
-          const select = await screen.findByText('Select branch')
-          await user.click(select)
-
           await waitFor(() =>
             expect(fetchNextPage).toHaveBeenCalledWith('some cursor')
           )

diff --git a/src/pages/RepoPage/CoverageTab/OverviewTab/Summary/Summary.test.jsx b/src/pages/RepoPage/CoverageTab/OverviewTab/Summary/Summary.test.jsx
@@ -363,7 +363,7 @@ describe('Summary', () => {
     describe('there is a next page', () => {
       it('calls fetchNextPage', async () => {
         const mockSetNewPath = vi.fn()
-        const { fetchNextPage, user } = setup({
+        const { fetchNextPage } = setup({
           hasNextPage: true,
           coverageRedirectData: {
             redirectState: {
@@ -378,11 +378,6 @@ describe('Summary', () => {
         })
         render(<Summary />, { wrapper: wrapper() })
 
-        const select = await screen.findByRole('button', {
-          name: 'select branch',
-        })
-        await user.click(select)
-
         await waitFor(() => expect(fetchNextPage).toHaveBeenCalled())
       })
     })

diff --git a/src/pages/RepoPage/CoverageTab/OverviewTab/SummaryTeamPlan/SummaryTeamPlan.test.tsx b/src/pages/RepoPage/CoverageTab/OverviewTab/SummaryTeamPlan/SummaryTeamPlan.test.tsx
@@ -348,7 +348,7 @@ describe('Summary', () => {
     describe('there is a next page', () => {
       it('calls fetchNextPage', async () => {
         const mockSetNewPath = vi.fn()
-        const { fetchNextPage, user } = setup({
+        const { fetchNextPage } = setup({
           isIntersecting: true,
           hasNextPage: true,
           coverageRedirectData: {
@@ -361,11 +361,6 @@ describe('Summary', () => {
         })
         render(<SummaryTeamPlan />, { wrapper: wrapper() })
 
-        const select = await screen.findByRole('button', {
-          name: 'select branch',
-        })
-        await user.click(select)
-
         await waitFor(() => expect(fetchNextPage).toHaveBeenCalled())
       })
     })

diff --git a/src/ui/FileViewer/ToggleHeader/ToggleHeader.test.tsx b/src/ui/FileViewer/ToggleHeader/ToggleHeader.test.tsx
@@ -6,19 +6,6 @@ import { MemoryRouter, Route } from 'react-router-dom'
 
 import ToggleHeader from './ToggleHeader'
 
-const mocks = vi.hoisted(() => ({
-  useIntersection: vi.fn(),
-}))
-
-vi.mock('react-use', async () => {
-  const original = await vi.importActual('react-use')
-
-  return {
-    ...original,
-    useIntersection: mocks.useIntersection,
-  }
-})
-
 const mockFlagResponse = {
   owner: {
     repository: {