Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up list_repos_page_size expt #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clean up list_repos_page_size expt #362

wants to merge 1 commit into from

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 19, 2024

fixes codecov/engineering-team#1757

the default value for users not in this experiment used to be 100 and now the hardcoded value is 50. this is because the experiment group which uses a page size of 50 was rolled out to 100% and the in-code default was just never updated.

@matt-codecov matt-codecov requested a review from a team September 19, 2024 18:41
joseph-sentry
joseph-sentry previously approved these changes Sep 19, 2024
@joseph-sentry
Copy link
Contributor

If this merges does this mean we can safely delete the Feature Flag in the Django Admin?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (c9d8b87) to head (a1be492).

Current head a1be492 differs from pull request most recent head 9b581df

Please upload reports for the commit 9b581df to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   89.75%   89.11%   -0.65%     
==========================================
  Files         376      324      -52     
  Lines       11660     9698    -1962     
  Branches     2065     1735     -330     
==========================================
- Hits        10465     8642    -1823     
+ Misses       1106      992     -114     
+ Partials       89       64      -25     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov
Copy link
Contributor Author

@joseph-sentry we could, but i think i would prefer to leave it in case we want to re-run the A/B test results for this experiment later. there is an "inactive" field on the model we can set which currently does nothing but could be made to act as a filter in the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate gracefully failing if we encount a 502 from GitHub during sync_repos
2 participants