Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update cryptography package version #240

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

joseph-sentry
Copy link
Contributor

@codecov-staging
Copy link

codecov-staging bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         370      370           
  Lines       29996    29996           
=======================================
  Hits        29437    29437           
  Misses        559      559           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.22% <ø> (ø)
OutsideTasks 97.94% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40690da) 98.13% compared to head (516dacf) 98.13%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         370      370           
  Lines       29996    29996           
=======================================
  Hits        29437    29437           
  Misses        559      559           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.22% <ø> (ø)
OutsideTasks 97.94% <ø> (ø)

Copy link

codecov-public-qa bot commented Jan 23, 2024

Codecov Report

Merging #240 (516dacf) into main (40690da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         370      370           
  Lines       29996    29996           
=======================================
  Hits        29437    29437           
  Misses        559      559           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.22% <ø> (ø)
OutsideTasks 97.94% <ø> (ø)

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40690da) 98.11% compared to head (516dacf) 98.11%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         401      401           
  Lines       30697    30697           
=======================================
  Hits        30117    30117           
  Misses        580      580           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.12% <ø> (ø)
OutsideTasks 97.94% <ø> (ø)

This change has been scanned for critical changes. Learn more

Copy link
Contributor

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you updated shared with this same version constraint in codecov/shared#106. i think if you update shared here you should get this constraint without needing to hardcode it in requirements.in? same goes for codecov-api which has its own issue: https://github.com/codecov/internal-issues/issues/178

@joseph-sentry joseph-sentry force-pushed the joseph/update-cryptography branch from 4d539a6 to 516dacf Compare January 24, 2024 16:14
@joseph-sentry joseph-sentry merged commit 292c555 into main Jan 24, 2024
31 checks passed
@joseph-sentry joseph-sentry deleted the joseph/update-cryptography branch January 24, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants