Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log sentry errors for upload processing errors #934

Merged
merged 1 commit into from
Dec 3, 2024
Merged

log sentry errors for upload processing errors #934

merged 1 commit into from
Dec 3, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Dec 3, 2024

emitting sentry errors allows us to see when, for instance, processing timeouts spike, and we can click through to specific traces to see what's regressed in sentry

@matt-codecov matt-codecov requested a review from a team December 3, 2024 18:50
@codecov-notifications
Copy link

codecov-notifications bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/__init__.py 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.96%. Comparing base (7b3a805) to head (21c0f5b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/__init__.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   97.97%   97.96%   -0.01%     
==========================================
  Files         446      446              
  Lines       35596    35601       +5     
==========================================
+ Hits        34874    34878       +4     
- Misses        722      723       +1     
Flag Coverage Δ
integration 42.07% <28.57%> (-0.01%) ⬇️
unit 90.65% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 3, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@matt-codecov matt-codecov added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 814fedd Dec 3, 2024
20 of 27 checks passed
@matt-codecov matt-codecov deleted the pr934 branch December 3, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants