Bundle Analysis: Display comparison for file paths on PR comments

requirements.in

@@ -1,5 +1,5 @@
 https://github.com/codecov/test-results-parser/archive/c840502d1b4dd7d05b2efc2c1328affaf2acd27c.tar.gz#egg=test-results-parser
-https://github.com/codecov/shared/archive/8c5de3fadd3c987304043c6cfd64864f372d674f.tar.gz#egg=shared
+https://github.com/codecov/shared/archive/0af6ba6385c84446beaf7f9917bf69ff1564c262.tar.gz#egg=shared
 https://github.com/codecov/timestring/archive/d37ceacc5954dff3b5bd2f887936a98a668dda42.tar.gz#egg=timestring
 asgiref>=3.7.2
 analytics-python==1.3.0b1

requirements.txt

@@ -328,7 +328,7 @@ sentry-sdk==2.13.0
     #   shared
 setuptools==75.6.0
     # via nodeenv
-shared @ https://github.com/codecov/shared/archive/8c5de3fadd3c987304043c6cfd64864f372d674f.tar.gz#egg=shared
+shared @ https://github.com/codecov/shared/archive/0af6ba6385c84446beaf7f9917bf69ff1564c262.tar.gz#egg=shared
     # via -r requirements.in
 six==1.16.0
     # via

services/bundle_analysis/notify/messages/comment.py

@@ -4,7 +4,7 @@
 import sentry_sdk
 from asgiref.sync import async_to_sync
 from django.template import loader
-from shared.bundle_analysis import BundleAnalysisComparison, BundleChange
+from shared.bundle_analysis import BundleAnalysisComparison, BundleChange, RouteChange
 from shared.torngit.exceptions import TorngitClientError
 from shared.validation.types import BundleThreshold
 
@@ -34,6 +34,14 @@ class BundleRow(TypedDict):
     is_change_outside_threshold: bool
 
 
+class BundleRouteRow(TypedDict):
+    route_name: str
+    change_size_readable: str
+    percentage_change_readable: str
+    change_icon: str
+    route_size: str
+
+
 class BundleCommentTemplateContext(TypedDict):
     pull_url: str
     total_size_delta: int
@@ -42,6 +50,7 @@ class BundleCommentTemplateContext(TypedDict):
     status_level: Literal["INFO"] | Literal["WARNING"] | Literal["ERROR"]
     warning_threshold_readable: str
     bundle_rows: list[BundleRow]
+    bundle_route_data: dict[str, list[BundleRouteRow]]
     has_cached_bundles: bool
 
 
@@ -70,13 +79,17 @@ def build_default_message(
         bundle_rows = self._create_bundle_rows(
             context.bundle_analysis_comparison, warning_threshold
         )
+        bundle_route_data = self._create_bundle_route_data(
+            context.bundle_analysis_comparison
+        )
         if warning_threshold.type == "absolute":
             warning_threshold_readable = bytes_readable(warning_threshold.threshold)
         else:
             warning_threshold_readable = str(round(warning_threshold.threshold)) + "%"
         context = BundleCommentTemplateContext(
             has_cached=any(row["is_cached"] for row in bundle_rows),
             bundle_rows=bundle_rows,
+            bundle_route_data=bundle_route_data,
             pull_url=get_bundle_analysis_pull_url(pull=context.pull.database_pull),
             total_size_delta=total_size_delta,
             status_level=context.commit_status_level.name,
@@ -159,7 +172,7 @@ def _create_bundle_rows(
 
             change_size = bundle_change.size_delta
             if change_size == 0:
-                # Don't include bundles that were not changes in the table
+                # Don't include bundles that were not changed in the table
                 continue
             icon = ""
             if change_size > 0:
@@ -184,3 +197,46 @@ def _create_bundle_rows(
             )
 
         return bundle_rows
+
+    def _create_bundle_route_data(
+        self,
+        comparison: BundleAnalysisComparison,
+    ) -> dict[str, list[BundleRouteRow]]:
+        """
+        Translate BundleRouteComparison dict data into a template compatible dict data
+        """
+        bundle_route_data = {}
+        changes_dict = comparison.bundle_routes_changes()
+
+        for bundle_name, route_changes in changes_dict.items():
+            rows = []
+            for route_change in route_changes:
+                change_size, icon = route_change.size_delta, ""
+                size = (
+                    "(removed)"
+                    if route_change.change_type == RouteChange.ChangeType.REMOVED
+                    else bytes_readable(route_change.size_head)
+                )
+
+                if change_size == 0:
+                    # Don't include bundles that were not changes in the table
+                    continue
+                elif change_size > 0:
+                    icon = ":arrow_up:"
+                elif change_size < 0:
+                    icon = ":arrow_down:"
+
+                rows.append(
+                    BundleRouteRow(
+                        route_name=route_change.route_name,
+                        change_size_readable=bytes_readable(change_size),
+                        percentage_change_readable=f"{route_change.percentage_delta}%",
+                        change_icon=icon,
+                        route_size=size,
+                    )
+                )
+
+            # Only include bundles that have routes
+            if rows:
+                bundle_route_data[bundle_name] = rows
+        return bundle_route_data

services/bundle_analysis/notify/messages/templates/bundle_analysis_notify/bundle_comment.md

@@ -7,4 +7,5 @@ Bundle size has no change :white_check_mark:
 {% if bundle_rows %}{% include "bundle_analysis_notify/bundle_table.md" %}{% if has_cached %}
 
 ℹ️ *Bundle size includes cached data from a previous commit
-{%endif%}{% endif %}
+{%endif%}{% endif %}
+{% if bundle_route_data %}{% include "bundle_analysis_notify/bundle_route_table.md" %}{% endif %}

services/bundle_analysis/notify/messages/templates/bundle_analysis_notify/bundle_route_table.md

@@ -0,0 +1,10 @@
+{% for bundle_name, routes in bundle_route_data.items %}
+<details>
+  <summary>View changes by path for bundle: {{ bundle_name }}</summary>
+
+| File path | Size | Change |
+| --------- | ---- | ------ |{% for bundle_route_row in routes %}
+| {{bundle_route_row.route_name}} | {{bundle_route_row.route_size}} | {{bundle_route_row.change_size_readable}} ({{bundle_route_row.percentage_change_readable}}) {{bundle_route_row.change_icon}}{{bundle_route_row.}} |{% endfor %}
+
+</details>
+{% endfor %}

services/bundle_analysis/notify/messages/tests/test_comment.py

@@ -66,7 +66,8 @@ def test_build_message_from_samples(self, dbsession, mocker, mock_storage):
                 | @codecov/bundler-plugin-core-cjs | 43.32kB | 611 bytes (1.43%) :arrow_up: |
                 | @codecov/example-next-app-server-cjs | (removed) | 342.32kB (-100.0%) :arrow_down: |
 
-                </details>""").format(
+                </details>
+                """).format(
             pullid=enriched_pull.database_pull.pullid,
             owner=head_commit.repository.owner.username,
             repo=head_commit.repository.name,