Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warning for Elixir 1.18 #281

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix compilation warning for Elixir 1.18 #281

merged 1 commit into from
Dec 10, 2024

Conversation

wkirschbaum
Copy link
Contributor

@wkirschbaum wkirschbaum commented Dec 10, 2024 •
edited
Loading

The following warning triggers on Elixir 1.18:

Compiling 1 file (.ex)
    warning: :error.new/1 is undefined (module :error is not available or is yet to be defined)
    │
 33 │         type.new(opts)
    │              ~
    │
    └─ lib/pigeon/apns/config_parser.ex:33:14: Pigeon.APNS.ConfigParser.parse/1

The solution was suggested here: elixir-lang/elixir#14043

@wkirschbaum
fix: tag config_type response to avoid compilation warning
c878dbe 
This will only happen on Elixir 1.18. The solution was suggested here: elixir-lang/elixir#14043
@wkirschbaum wkirschbaum changed the title fix: tag config_type response to avoid compilation warning Fix compilation warning for Elixir 1.18 Dec 10, 2024
@hpopp
Copy link
Member

hpopp commented Dec 10, 2024

Thanks for this!

@hpopp hpopp merged commit 0a54039 into codedge-llc:master Dec 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkirschbaum @hpopp