Updates the image to use Eclipse Temurin project's image #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
changed the title
bseeger
force-pushed
the
updates_dockerfile_image
branch
from
9f1823d to
76ced88
Compare
Co-Authored-By: Cypress Borg; [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Why?'s
The OpenJdk Image was deprecated and the docker hub page encourages folks to move off those images (though it's not clear if it was just for specific versions or just the earlier ones).
We also had an issue where the original OpenJdk was missing a library we need. We could probably work through this issue, but given that the OpenJdk image is deprecated, it seems wise to move away from that image.
General Details
The image from below is created by the AdoptOpenJdk group, which is now known as Eclipse Adoptium, with a sub project called Termurin.
There are many image versions for us to choose from. I picked one that is close to the java version we were using in OpenJdk (17.0). We could go more general and just use
eclipse-temurin:17, which I suspect is always the latest Java 17 release. Thoughts?I tried this out and the image builds fine and seems to run fine.
I found this writeup confirms what I was learning: https://developers.redhat.com/articles/2022/09/16/updating-docker-hubs-openjdk-image#docker_hub_deprecates_openjdk_images