-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
619/refactor image upload button #680
base: Development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick, could we have a small text right under the image icon (perhaps in white text) to let users know what it's for? For someone that's not tech-savvy, it's not immediately clear that I would need to click don't the image to change the image.
Think it's mostly just the test and linter at the moment, other than that, this looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI looks good, but I can't seem to upload any images as my profile image.
Screen.Recording.2024-10-09.at.2.11.26.PM.mov
Odd. It's working for me. |
This works for me as well. I did a pair testing session with @leekahung and we were not able to figure out why it will not work. I think we should figure out why it works for some of us before merging in. The previous functionality in development works for all of us so we will have to dig in a little bit more and see what changed. |
This PR:
Resolves #619
1. Removes "Choose/Remove Img" button on the Profile page and refactors it as a hover effect directly over the avatar
2. This approach more closely matches the way many services program the same functionality, so it ought to be intuitive enough for users
Screenshots (if applicable):
No photo uploaded:
No photo uploaded (plus hover):
With photo uploaded:
With photo uploaded (plus hover):
Additional Context (optional):
The goal is to make the Profile card less crowded-looking without sacrificing ease of use.
Future Steps/PRs Needed to Finish This Work (optional):