Delete unused packges and file; Non-docker local dev #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindblight
commented
Sep 10, 2022
| @@ -1,4 +1,4 @@ | |||
| const axios = require('axios'); | |||
| require("dotenv").config(); | |||
There was a problem hiding this comment.
💬 This library loads the contents of .env file into process.env. It makes local development a lot easier.
mindblight
commented
Sep 10, 2022
| @@ -1,6 +1,5 @@ | |||
| var request = require('request'); | |||
| var GtfsRealtimeBindings = require('gtfs-realtime-bindings'); | |||
| const { reject } = require('lodash'); | |||
There was a problem hiding this comment.
💬 This was imported but unused.
mindblight
commented
Sep 10, 2022
| @@ -1,4 +1,4 @@ | |||
| const axios = require('axios'); | |||
| "gtfs-realtime-bindings": "^0.0.5", | ||
| "luxon": "^2.3.0", | ||
| "request": "^2.88.0", | ||
| "zlib": "^1.0.5" | ||
| }, | ||
| "devDependencies": { | ||
| "jest": "^27.5.1", | ||
| "lodash": "^4.17.11" |
There was a problem hiding this comment.
💬 If we want to add lodash back, it likely needs to go under dependencies rather than devDependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
lodashlibrary. It wasn't being usedfslibrary.fsis built into node. That library is a security placeholder put in place by NPM to prevent malicious actors from coopting the package for supply chain attacks.Testing
Try following the
Directly via npm run startdirections in the readme, and confirm files are written totmp/