fix add-cluster for helm runtime (#686)

* fix add-cluster for helm runtime * bump
codefresh-io · Mar 27, 2023 · bf42a1b · bf42a1b
1 parent 88d88ac
commit bf42a1b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/Makefile b/Makefile
@@ -1,4 +1,4 @@
-VERSION=v0.1.40
+VERSION=v0.1.41
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

diff --git a/cmd/commands/runtime.go b/cmd/commands/runtime.go
@@ -1168,7 +1168,7 @@ func getRuntimeNamespace(cmd *cobra.Command, runtimeName string, runtimeVersion
 	hasdifferentNamespaceSupport := runtimeVersion.GreaterThan(differentNamespaceSupportVer)
 
 	if !hasdifferentNamespaceSupport {
-		log.G().Infof("To specify a different namespace please use runtime version >= %s", differentNamespaceSupportVer.String())
+		log.G().Infof("To specify a different namespace please use runtime version > %s", differentNamespaceSupportVer.String())
 		_ = cmd.Flag("namespace").Value.Set("")
 		return namespace
 	}

diff --git a/cmd/commands/runtime_install.go b/cmd/commands/runtime_install.go
@@ -606,7 +606,7 @@ func createRuntimeOnPlatform(ctx context.Context, opts *RuntimeInstallOptions, r
 	repoURL := opts.InsCloneOpts.URL()
 	runtimeArgs := &platmodel.RuntimeInstallationArgs{
 		RuntimeName:      opts.RuntimeName,
-		RuntimeNamespace: opts.RuntimeNamespace,
+		RuntimeNamespace: &opts.RuntimeNamespace,
 		Cluster:          rt.Spec.Cluster,
 		Managed:          new(bool),
 		RuntimeVersion:   rt.Spec.Version.String(),

diff --git a/docs/releases/release_notes.md b/docs/releases/release_notes.md
@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.40/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.41/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.40/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.1.41/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

diff --git a/go.mod b/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/argoproj/argo-events v0.17.1-0.20220327045437-70eaafe9afec
 	github.com/argoproj/argo-workflows/v3 v3.3.1
 	github.com/briandowns/spinner v1.18.1
-	github.com/codefresh-io/go-sdk v0.52.0
+	github.com/codefresh-io/go-sdk v0.54.0
 	github.com/fatih/color v1.13.0
 	github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
 	github.com/go-git/go-billy/v5 v5.3.1

diff --git a/go.sum b/go.sum
@@ -301,8 +301,8 @@ github.com/cockroachdb/datadriven v0.0.0-20200714090401-bf6692d28da5/go.mod h1:h
 github.com/cockroachdb/errors v1.2.4/go.mod h1:rQD95gz6FARkaKkQXUksEje/d9a6wBJoCr5oaCLELYA=
 github.com/cockroachdb/logtags v0.0.0-20190617123548-eb05cc24525f/go.mod h1:i/u985jwjWRlyHXQbwatDASoW0RMlZ/3i9yJHE2xLkI=
 github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI=
-github.com/codefresh-io/go-sdk v0.52.0 h1:s+O87OebisNiDOEsh3qSAB8gDJ+Sc6WmBOh8AaFlm/o=
-github.com/codefresh-io/go-sdk v0.52.0/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
+github.com/codefresh-io/go-sdk v0.54.0 h1:C1A2kTNXZqpvAkpAbZn8D9clr67nJRtdeFPd4QFIEWU=
+github.com/codefresh-io/go-sdk v0.54.0/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
 github.com/codegangsta/inject v0.0.0-20150114235600-33e0aa1cb7c0/go.mod h1:4Zcjuz89kmFXt9morQgcfYZAYZ5n8WHjt81YYWIwtTM=
 github.com/codeskyblue/go-sh v0.0.0-20190412065543-76bd3d59ff27/go.mod h1:VQx0hjo2oUeQkQUET7wRwradO6f+fN5jzXgB/zROxxE=
 github.com/container-storage-interface/spec v1.5.0/go.mod h1:8K96oQNkJ7pFcC2R9Z1ynGGBB1I93kcS6PGg3SsOk8s=