Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dind env vars #451

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix: dind env vars #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ccc295
fix: dind env vars
mikhail-klimko Apr 4, 2024
2bc121d
fix tests
mikhail-klimko Apr 4, 2024
2d4729d
Merge branch 'release-1.0' of https://github.com/codefresh-io/venona …
masontikhonov Apr 10, 2024
d337d44
docs: update Readme
masontikhonov Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions charts/cf-runtime/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: A Helm chart for Codefresh Runner
name: cf-runtime
version: 6.3.17
version: 6.3.18
keywords:
- codefresh
- runner
Expand All @@ -13,10 +13,10 @@ maintainers:
- name: codefresh
url: https://codefresh-io.github.io/
annotations:
artifacthub.io/containsSecurityUpdates: "true"
artifacthub.io/containsSecurityUpdates: "false"
artifacthub.io/changes: |
- kind: changed
description: Upgrade dind to 25.0.4-1.28.5
- kind: fixed
description: Fix runtime template for dind env vars
dependencies:
- name: cf-common
repository: oci://quay.io/codefresh/charts
Expand Down
2 changes: 1 addition & 1 deletion charts/cf-runtime/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Codefresh Runner

![Version: 6.3.17](https://img.shields.io/badge/Version-6.3.17-informational?style=flat-square)
![Version: 6.3.18](https://img.shields.io/badge/Version-6.3.18-informational?style=flat-square)

Helm chart for deploying [Codefresh Runner](https://codefresh.io/docs/docs/installation/codefresh-runner/) to Kubernetes.

Expand Down
2 changes: 1 addition & 1 deletion charts/cf-runtime/templates/runtime/runtime-env-spec-tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ dockerDaemonScheduler:
userAccess: {{ . }}
{{- end }}
{{- with $dindContext.env }}
env: {{- toYaml . | nindent 4 }}
envVars: {{- toYaml . | nindent 4 }}
{{- end }}
cluster:
namespace: {{ .Release.Namespace }}
Expand Down
2 changes: 1 addition & 1 deletion charts/cf-runtime/tests/runtime/runtime_onprem_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ tests:
type: DindKubernetesPod
dindImage: "quay.io/codefresh/dind:tagoverride"
userAccess: true
env:
envVars:
ALICE: BOB
cluster:
namespace: codefresh
Expand Down
2 changes: 1 addition & 1 deletion charts/cf-runtime/tests/runtime/runtime_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ tests:
type: DindKubernetesPod
dindImage: "quay.io/codefresh/dind:tagoverride"
userAccess: true
env:
envVars:
ALICE: BOB
cluster:
namespace: codefresh
Expand Down