Merge pull request #239 from codegouvfr/href-external-actions

href: replace mailto by string
codegouvfr · Mar 4, 2024 · 9ae9cc5 · 9ae9cc5
2 parents 25efba3 + 89c3f5c
commit 9ae9cc5
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/src/link.tsx b/src/link.tsx
@@ -17,12 +17,7 @@ export type RegisteredLinkProps = RegisterLink extends { Link: infer Link }
     ?
           | Omit<UnpackProps<Link>, "children">
           | (Omit<HTMLAnchorProps, "children" | "href"> & {
-                href:
-                    | `mailto:${string}`
-                    | `//${string}`
-                    | `https://${string}`
-                    | `http://${string}`
-                    | `#${string}`;
+                href: string;
             })
     : Omit<HTMLAnchorProps, "children">;
 
@@ -75,14 +70,6 @@ export function setLink(params: { Link: typeof Link }): void {
                 return <button {...rest} className={cx(fr.cx("fr-link"), rest.className)} />;
             }
 
-            mailto: {
-                if (target === undefined || !target.startsWith("mailto:")) {
-                    break mailto;
-                }
-
-                return <a href={target} {...rest} />;
-            }
-
             external_links: {
                 if (
                     target === undefined ||
@@ -101,6 +88,16 @@ export function setLink(params: { Link: typeof Link }): void {
 
                 return <a href={target} {...rest} />;
             }
+
+            uri_scheme: {
+                // Check if the 'target' starts with a valid URI scheme (e.g., 'mailto:', 'tel:', 'skype:', 'facetime:', etc.)
+                const regex = /^[a-z]+:/;
+                if (target === undefined || !regex.test(target)) {
+                    break uri_scheme;
+                }
+
+                return <a href={target} {...rest} />;
+            }
         }
 
         return <params.Link {...props} />;