Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LargeHeaderSubtitleComponent #29

Merged

Conversation

aharwood9
Copy link
Contributor

@aharwood9 aharwood9 commented Mar 1, 2024

Description

Closes #24. Adds a LargeHeaderSubtitleComponent to all the containers so that a component can be added to the ListHeaderComponent/ScrollView.

Motivation and Context

I would like to add additional components to the ListHeader that don't get impact the header animation. For example, several lines of text.

How Has This Been Tested?

This has been tested in both the Simple ScrollView and the FlatList in the example. I have added the subtitle to the ScrollView for future testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have followed the guidelines in the README.md file.
  • I have updated the documentation as necessary.
  • My changes generate no new warnings.

Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-03-01 at 10 39 10

Additional Notes (Optional)

Please include any additional information or context that may be helpful for the reviewer.

@aharwood9
Copy link
Contributor Author

@e-younan - This should be ready for review. I have updated the simple example to use the new subtitle header as the subtitle is relatively simple and don't want to impact the design of the twitter one etc.

I have updated the docs to include the new prop as well. I am not sure how you want to visualise this - I am not sure if this is required.

Copy link
Member

@e-younan e-younan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@e-younan e-younan merged commit b78414e into codeherence:main Mar 2, 2024
3 checks passed
@e-younan
Copy link
Member

e-younan commented Mar 2, 2024

Feel free to check out the latest version on npm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants