Skip to content

Commit

Permalink
Merge pull request #8854 from sahilKhatik/develop
Browse files Browse the repository at this point in the history
docs: Resolved phpstan error in Config/Filters.php
  • Loading branch information
kenjis authored May 5, 2024
2 parents 759344e + acf3e6c commit fd9cb65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
11 changes: 0 additions & 11 deletions phpstan-baseline.php
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
<?php declare(strict_types = 1);

$ignoreErrors = [];
$ignoreErrors[] = [
'message' => '#^PHPDoc type array\\<string, array\\<int, string\\>\\> of property Config\\\\Filters\\:\\:\\$methods is not the same as PHPDoc type array of overridden property CodeIgniter\\\\Config\\\\Filters\\:\\:\\$methods\\.$#',
'count' => 1,
'path' => __DIR__ . '/app/Config/Filters.php',
];
$ignoreErrors[] = [
'message' => '#^PHPDoc type array\\<string, array\\<string, array\\<int, string\\>\\>\\> of property Config\\\\Filters\\:\\:\\$filters is not the same as PHPDoc type array of overridden property CodeIgniter\\\\Config\\\\Filters\\:\\:\\$filters\\.$#',
'count' => 1,
Expand Down Expand Up @@ -1151,11 +1145,6 @@
'count' => 1,
'path' => __DIR__ . '/system/Config/Filters.php',
];
$ignoreErrors[] = [
'message' => '#^Property CodeIgniter\\\\Config\\\\Filters\\:\\:\\$methods type has no value type specified in iterable type array\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Config/Filters.php',
];
$ignoreErrors[] = [
'message' => '#^Accessing offset \'SERVER_PROTOCOL\' directly on \\$_SERVER is discouraged\\.$#',
'count' => 1,
Expand Down
2 changes: 2 additions & 0 deletions system/Config/Filters.php
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ class Filters extends BaseConfig
* If you use this, you should disable auto-routing because auto-routing
* permits any HTTP method to access a controller. Accessing the controller
* with a method you don't expect could bypass the filter.
*
* @var array<string, list<string>>
*/
public array $methods = [];

Expand Down

0 comments on commit fd9cb65

Please sign in to comment.