apply rector: set variable name to camel case

[samsonasik]

@MGatner here I try apply variable name to camel case checker with Rector.

Checklist:

• Securely signed commits
• Conforms to style guide

[michalsn]

From the first look - I think we would need a rule that leaves the initial underscore, e.g. replacing $_str variable to $str is not desired.

[samsonasik]

we can extends the rule with skip variable with _ in first char if needed.

[samsonasik]

@michalsn I've added utils/Rector/UnderscoreToCamelCaseLocalVariableNameRector.php for skip '_' in first character.

[MGatner]

This is looking great! I'm going to apply this to a few projects as well.

[michalsn]

This looks really good. Only Travis seem to have some hiccup - all tests hanged at the same time. We have to try to rerun this.

[samsonasik]

close reopen to restart travis build

[samsonasik]

it seems the dependency cause a very long running phpunit

[samsonasik]

trying with distributed rector-prefixed phar with require-dev nette/utils

[samsonasik]

Travis build green 🎉

[michalsn]

Yay, you made the tests work!

I think this is a good start and this can be merged.

It would be great if we could check the possibility of handling the parameters for functions as well in the separate PR. @MGatner do you think that this type of change would be a good idea?

Of course there is no hurry.

[samsonasik]

@michalsn I've updated to update both parameter and @param docblock

[samsonasik]

All green 🎉 🎉 🎉

[michalsn]

It looks great to me! Let's wait if others have anything to add.

[MGatner]

This should use the Composer cache so it can benefit from all the other running workflows. E.g from test-phpstan.yml:

      - name: Get composer cache directory
        id: composer-cache
        run: echo "::set-output name=dir::$(composer config cache-files-dir)"

      - name: Create composer cache directory
        run: mkdir -p ${{ steps.composer-cache.outputs.dir }}

      - name: Cache composer dependencies
        uses: actions/cache@v2
        with:
          path: ${{ steps.composer-cache.outputs.dir }}
          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
          restore-keys: ${{ runner.os }}-composer-

[samsonasik]

implemented.

[samsonasik]

I think it is ready. We can try use rector/rector instead of current alternative rector/rector-prefixed for more stable dependencies check later after #3689 as if using rector/rector, travis build is too slow.