Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed installation images and typo #7961

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

sammyskills
Copy link
Contributor

Description

See https://forum.codeigniter.com/showthread.php?tid=88400&pid=412786#pid412786

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Sep 21, 2023

Thank you.
But the DebugBar's numbers are very big.
Is really your clean CI4 slow and used the memory that much?

I checked with PHP 8.1 and spark serve, but I got around 20ms.

PHP 8.1.23 (cli) (built: Aug 31 2023 19:06:23) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.23, Copyright (c) Zend Technologies
    with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans
    with Zend OPcache v8.1.23, Copyright (c), by Zend Technologies

Screenshot 2023-09-22 6 46 31

@kenjis kenjis added the documentation Pull requests for documentation only label Sep 21, 2023
@sammyskills
Copy link
Contributor Author

Interestingly, I didn't pay much attention to that until now.

My CI4 has just shield installed and I'm beginning to wonder why it is that much. I use PHP 8.2.

I'll check and revert accordingly.

@kenjis
Copy link
Member

kenjis commented Sep 21, 2023

I checked clean CI4 (develop) with no change.

@sammyskills
Copy link
Contributor Author

After uninstalling shield, the best I could get is around 75ms. I don't know if it has to do with my system configuration (windows) or not.
image

@sammyskills
Copy link
Contributor Author

Maybe I'll replace the debugbar image with the one from your system?

@ddevsr
Copy link
Collaborator

ddevsr commented Sep 22, 2023

You need screenshot fresh install, it just describes the application for the first time

@kenjis
Copy link
Member

kenjis commented Sep 22, 2023

The screenshot should be taken with the fresh installation of CI4.
I'm fine with your screenshot if it is a fresh installation.

It seems Windows PHP needs more memory than macOS.
The time depends on systems. If you use more faster machine, it will be shorter.
Do you use HDD or SSD?

@sammyskills
Copy link
Contributor Author

You need screenshot fresh install, it just describes the application for the first time

The screenshot I used is for a fresh install

Do you use HDD or SSD?

1TB SSD, 16GB RAM, Core i5

It seems Windows PHP needs more memory than macOS.

I have memory_limit = 512M in my php.ini. Do I need to increase it?

@datamweb
Copy link
Contributor

@sammyskills The output for me is as follows.

Just CI4.4.1:

Screenshot 2023-09-22 093852

CI4.4.1 + Shield(dev branch)

Screenshot 2023-09-22 094651

Info :

P:\ci4\ci441>php -v
PHP 8.1.5 (cli) (built: Apr 12 2022 17:38:57) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.1.5, Copyright (c) Zend Technologies
    with Xdebug v3.1.4, Copyright (c) 2002-2022, by Derick Rethans

@sammyskills
Copy link
Contributor Author

@datamweb, here's my php version output:

php -v
PHP 8.2.6 (cli) (built: May  9 2023 16:02:16) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.2.6, Copyright (c) Zend Technologies
    with Xdebug v3.2.2, Copyright (c) 2002-2023, by Derick Rethans

@kenjis
Copy link
Member

kenjis commented Sep 22, 2023

I have memory_limit = 512M in my php.ini. Do I need to increase it?

No. If your app runs well, the smaller memory limit is better.

@kenjis
Copy link
Member

kenjis commented Sep 22, 2023

1TB SSD, 16GB RAM, Core i5

My MBA has 512GB SSD, 16GB RAM, Core i5.

@sammyskills
Copy link
Contributor Author

I have updated the debugbar image with another fresh install, but the load time is still >70ms.

@datamweb
Copy link
Contributor

but the load time is still >70ms.

@sammyskills I upgraded php to 8.2.6, the result is interesting!!

Just CI4.4.1:

ci441

CI4.4.1+Shield:

ci441shield

P:\ci4\CI441>php -v
PHP 8.2.6 (cli) (built: May  9 2023 16:02:16) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.2.6, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.6, Copyright (c), by Zend Technologies

@kenjis
Copy link
Member

kenjis commented Sep 22, 2023

@datamweb It is because you don't install/enable Xdebug.

@sammyskills
Copy link
Contributor Author

@datamweb, interesting indeed!

Seeing that you also use a windows system, do you mind sharing your specific setup?

My PC is 1TB SSD, 16GB RAM, Core i5 and I use laragon to handle my development environment (php, mysql, etc).

@sammyskills
Copy link
Contributor Author

@datamweb It is because you don't install/enable Xdebug.

@kenjis you are right. I disabled Xdebug and the load time reduced to 66ms.

@datamweb
Copy link
Contributor

datamweb commented Sep 22, 2023

It is because you don't install/enable Xdebug.

Yes, it has an effect.
Just CI441:

ci441+xd

CI441+shield :

ci4+shield+xd

P:\ci4\CI441>php -v
PHP 8.2.6 (cli) (built: May  9 2023 16:02:16) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.2.6, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.6, Copyright (c), by Zend Technologies
    with Xdebug v3.2.2, Copyright (c) 2002-2023, by Derick Rethans
Device name	Pooya
Processor	AMD Ryzen 9 3900X 12-Core Processor               3.80 GHz
Installed RAM	16.0 GB

Edition	Windows 11 Home
Version	21H2
Installed on	‎10/‎8/‎2021
OS build	22000.1219
Experience	Windows Feature Experience Pack 1000.22000.1219.0

Samsung SSD 980 PRO 250GB 

use laragon to handle my development environment (php, mysql, etc).

I installed PHP directly. But my MySQL is installed by Xampp.

@sammyskills
Copy link
Contributor Author

I installed PHP directly. But my MySQL is installed by Xampp.

Installing PHP directly might be the game-changer.

@kenjis kenjis merged commit 8847002 into codeigniter4:develop Sep 24, 2023
4 checks passed
@kenjis
Copy link
Member

kenjis commented Sep 24, 2023

@sammyskills Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants