Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sample code in "Creating Core System Classes" #8205

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

webalchemist
Copy link
Contributor

@webalchemist webalchemist commented Nov 14, 2023

RouteCollection constructor parameters are out of date in the Creating Core System Classes docs. Minor point, but might save someone a few minutes working out what they should be.

Referenced in <#8204>

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Updated RouteCollection constructor parameters
@kenjis kenjis added the documentation Pull requests for documentation only label Nov 14, 2023
@kenjis kenjis changed the title Update 002.php docs: update sample code in "Creating Core System Classes" Nov 14, 2023
@kenjis
Copy link
Member

kenjis commented Nov 14, 2023

Please fix the coding style.

   1) user_guide_src/source/extending/core_classes/002.php (spaces_inside_parentheses)
      ---------- begin diff ----------
--- /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/extending/core_classes/002.php
+++ /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/extending/core_classes/002.php
@@ -12,7 +12,7 @@
             return static::getSharedInstance('routes');
         }
 
-        return new \App\Libraries\RouteCollection(static::locator(), config(Modules::class), config(Routing::class) );
+        return new \App\Libraries\RouteCollection(static::locator(), config(Modules::class), config(Routing::class));
     }
 
     // ...

      ----------- end diff -----------


Found 1 of 1543 files that can be fixed in 4.749 seconds, 32.000 MB memory used

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6858254373/job/18648874735?pr=8205

@kenjis
Copy link
Member

kenjis commented Nov 22, 2023

Can you fix the coding style?

@kenjis kenjis added the waiting for info Issues or pull requests that need further clarification from the author label Nov 22, 2023
@MGatner MGatner merged commit 14b4350 into codeigniter4:develop Nov 25, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants