Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add return type to closuer in FilterCheck #9190

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

neznaika0
Copy link
Contributor

Description
Fix return type

> vendor/bin/rector process --dry-run
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
1 file with changes
===================

1) system/Commands/Utilities/FilterCheck.php:166

    ---------- begin diff ----------
@@ @@
      */
     private function colorItems(array $array): array
     {
-        return array_map(function ($item) {
+        return array_map(function ($item): array|string {
             if (is_array($item)) {
                 return $this->colorItems($item);
             }
    ----------- end diff -----------

Applied rules:
 * ClosureReturnTypeRector

@kenjis kenjis changed the title fix: rector notify refactor: rector notify Sep 15, 2024
@kenjis kenjis added refactor Pull requests that refactor code 4.6 labels Sep 15, 2024
@kenjis kenjis changed the title refactor: rector notify refactor: return type to closuer in FilterCheck Sep 15, 2024
@kenjis kenjis merged commit 0735e19 into codeigniter4:4.6 Sep 15, 2024
45 checks passed
@kenjis kenjis changed the title refactor: return type to closuer in FilterCheck refactor: add return type to closuer in FilterCheck Sep 15, 2024
@neznaika0 neznaika0 deleted the fix-rector-return-type branch September 15, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants