Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resend Code Verification Time #1147

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

warcooft
Copy link
Contributor

@warcooft warcooft commented Jul 17, 2024

Description

This pull request provides a delay time for each verification code sent to the user's email to avoid spam when the user continuously refreshes the page, improving performance and a comfortable experience for the user.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the tests needed Pull requests that need tests label Jul 17, 2024
@kenjis
Copy link
Member

kenjis commented Jul 17, 2024

Please fix errors in GitHub Action checks, and add test code.
Reference: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

@kenjis kenjis added the enhancement New feature or request label Jul 18, 2024
@kenjis
Copy link
Member

kenjis commented Aug 26, 2024

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests
added to our test suite to prove the code works.

This PR does not have the necessary test code. If you want this PR to be reviewed, please add the test code.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

If the test is not added, this PR will be closed.

@warcooft warcooft marked this pull request as draft August 27, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests needed Pull requests that need tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants