Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update active date only for users activated and not banned. #1184

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: Update active date only for users activated and not banned. #1184

wants to merge 4 commits into from

Conversation

warcooft
Copy link
Contributor

@warcooft warcooft commented Aug 26, 2024 •
edited
Loading

Description
See #1179 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb changed the title feat: Update active date only for users activated and not banned. fix: Update active date only for users activated and not banned. Aug 26, 2024
@datamweb datamweb added the bug Something isn't working label Aug 26, 2024
datamweb
datamweb approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@kenjis kenjis added the tests needed Pull requests that need tests label Aug 26, 2024
@kenjis
Copy link
Member

kenjis commented Aug 26, 2024

Because the existing PHPUnit tests do not fail, there seems no test code for recordActiveDate.
I would like you to add test code:

  • does not update active date for a user that is not activated
  • does not update active date for a user that is banned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warcooft @kenjis @datamweb