Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi level permissions in can() #1227

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

bgeneto
Copy link
Contributor

@bgeneto bgeneto commented Nov 9, 2024

When using asterisk (*) to give user/group permissions, only one level permissions are supported by can(). This resolves #1224

Description
Changed files:

  • tests/Authorization/GroupTest.php
  • src/Entities/Group.php
  • src/Authorization/Traits/Authorizable.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

takes into consideration multilevel permissions.
takes into consideration multiple permissions levels
test to check multi level permissions properly
when using asterisk (*) to give user/group permissions, only one level permissions are supported by can(). This resolves codeigniter4#1224
@CosDiabos
Copy link

Hey!

The PR title must start with the type (feat, fix, chore, docs, perf, refactor, style, test, lang) of the commit per Conventional Commits, in this case fix:

Run Rector and cs fix to fix code style:

vendor/bin/rector && composer cs-fix

And lastly, all your commits need to be signed or it wont be merged. You can find more info here on how to create a signature and here how to sign previously unsigned commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: authorization using asterisk (*) only works one level
2 participants