-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[김현우] sprint11 #164
Open
Accreditus
wants to merge
12
commits into
codeit-sprint-fullstack:next-김현우
Choose a base branch
from
Accreditus:CODEIT_SPRINT_MISSION_11
base: next-김현우
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[김현우] sprint11 #164
Accreditus
wants to merge
12
commits into
codeit-sprint-fullstack:next-김현우
from
Accreditus:CODEIT_SPRINT_MISSION_11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accreditus
added
매운맛 🔥
뒤는 없습니다. 그냥 필터 없이 말해주세요. 책임은 제가 집니다.
진행 중 🏃
아직 스프린트 미션 제출일이 아닙니다. 새로 커밋된 내용에 대해 코드리뷰 해주세요!
labels
Nov 10, 2024
wildCodingWarrior
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어디서 따로 학습을 하고 오신건가요?
Express 사용없이 nextjs만으로 풀스택 앱을 구동하신 것으로 보이네요.
NextAuth부터 trpc까지 아주 잘 사용하셨습니다.
특히 trpc 사용으로 서버와 클라이언트에서 같은 타입 공유하는 부분이 정말 편해보입니다.
코드리뷰하면서 잠깐 알아봤는데 단순한 API 구축하고 제작하는데 있어서 정말 편리함을 느꼈습니다. 대단하네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
공통
-[ ] Github에 위클리 미션 PR을 만들어 주세요.
-[ ] React 및 Express를 사용해 진행합니다.
-[ ] TypeScript를 활용해 프로젝트의 필요한 곳에 타입을 명시해 주세요.
-[ ] any 타입의 사용은 최소화해 주세요.
-[ ] 복잡한 객체 구조나 배열 구조를 가진 변수에 인터페이스 또는 타입 별칭을 사용하세요.
-[ ] Union, Intersection, Generics 등 고급 타입을 적극적으로 사용해 주세요.
-[ ] 타입 별칭 또는 유틸리티 타입을 사용해 타입 복잡성을 줄여주세요.
-[ ] 타입스크립트 컴파일러가 에러 없이 정상적으로 작동해야 합니다.
프론트엔드
-[ ] 기존 React(혹은 Next) 프로젝트를 타입스크립트 프로젝트로 마이그레이션 해주세요.
-[ ] TypeScript를 활용해 프로젝트의 필요한 곳에 타입을 명시해 주세요.
주요 변경사항
멘토에게