Abstract transports & and add akka-http http/websocket backend #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves some of the generic code in the servlet transports/connections into the common module.
kelnos
force-pushed
the
transport-abstraction
branch
4 times, most recently
from
5cb1fd4
to
b0f39d6
Compare
kelnos
force-pushed
the
transport-abstraction
branch
from
b0f39d6
to
b601817
Compare
When the client doesn't provide a session ID when connecting, we can't call Transport.getConnection() after Transport.handle() returns, because the transport machinery will see that there's still no session ID in the request parameters, and create a new session. This session won't have an associated request, so things later will start failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to use a socket.io server implementation in an akka-http-based project I'm working on, so I thought I'd try my hand at removing the Servlet dependencies out of the core API. Essentially what I've done:
HttpRequestandHttpResponseinterfaces that abstract the methods used fromHttpServletRequestandHttpServletResponse, and have the socket.io APIs use the interface rather than the servlet implementations.init()methods in the transport interfaces, and have them provided "internally" by the servlet transport implementations.Right now it's only building for Scala 2.12; cross-compiles are notoriously annoying to do with maven (to do it right you pretty much have to have multiple POMs), so I'm punting on that for now.