Add support for SYCL on example 35 #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AD2605
approved these changes
Oct 14, 2024
| @@ -159,6 +165,8 @@ struct Options { | |||
| /// Returns true if the environment and Toolkit support this | |||
| bool supported(bool verbose = true) const { | |||
|
|
|||
| #if !defined(CUTLASS_ENABLE_SYCL) | |||
There was a problem hiding this comment.
This is only temporary needed until we rework how __CUDACC_VER_MAJOR__ works for syclcompat, right? If so a code comment would be good so that we can find those easily in the future.
| @@ -513,6 +525,10 @@ struct Testbed { | |||
| ElementCompute(0) | |||
| ); | |||
|
|
|||
| #if defined(CUTLASS_ENABLE_SYCL) | |||
| syclcompat::wait(); | |||
There was a problem hiding this comment.
why is that extra wait needed? Should probably be a code comment.
| auto gemm_event = launch<cutlass::Kernel<GemmKernel>>(launch_policy{ | ||
| sycl_grid, sycl_block, local_mem_size{static_cast<std::size_t>(gemm_smem_size)}}, | ||
| params_.gemm); | ||
| EventManager::getInstance().addEvent(gemm_event); |
There was a problem hiding this comment.
why does the event need to be recorded? (a general question for each launch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SYCL to the original Cutlass 2 example 35. The focus of this PR is only on functionality. Performance optimisations will be addressed in a separate PR to ensure that execution with SYCL can match the performance achieved with cuda.