Fix B matrix layout #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-goli
approved these changes
Jun 19, 2024
mehdi-goli
reviewed
Jun 19, 2024
mehdi-goli
reviewed
Jun 19, 2024
mehdi-goli
reviewed
Jun 19, 2024
mehdi-goli
reviewed
Jun 19, 2024
Co-authored-by: Mehdi Goli <[email protected]>
Co-authored-by: Mehdi Goli <[email protected]>
Co-authored-by: Mehdi Goli <[email protected]>
Co-authored-by: Mehdi Goli <[email protected]>
mehdi-goli
reviewed
Jun 19, 2024
Co-authored-by: Mehdi Goli <[email protected]>
mehdi-goli
approved these changes
Jun 19, 2024
aacostadiaz
added a commit
that referenced
this pull request
Jul 16, 2024
* Use N major for B * Use N major for B coordinates * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Fix A copy trait layout * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]>
aacostadiaz
added a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
* Use N major for B * Use N major for B coordinates * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> * Fix A copy trait layout * Update include/cute/atom/copy_traits_xe.hpp Co-authored-by: Mehdi Goli <[email protected]> --------- Co-authored-by: Mehdi Goli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the B matrix was defined as row-major, while Cutlass internally uses M, N, or K major to define matrices.