Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with dependencies in nrm2 #451

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

aacostadiaz
Copy link
Collaborator

This PR fixes an issue with dependencies in nrm2. Previously, the operations could finish without computing the sqrt operation. This was because the dependency tree was not correctly constructed. This PR fixes the issue by correctly constructing the dependency tree, which ensures that all operations are computed in the correct order.

@aacostadiaz aacostadiaz added the stacked PR is stacked on top of another label Jul 28, 2023
Copy link
Collaborator

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

test/unittest/blas1/blas1_nrm2_test.cpp Outdated Show resolved Hide resolved
This PR fixes an issue with dependencies in TBMV (similar to the fix in #451)
@OuadiElfarouki OuadiElfarouki self-requested a review August 9, 2023 15:55
@aacostadiaz aacostadiaz merged commit 38e35d7 into aacosta/fix_negative_inc Aug 10, 2023
5 checks passed
aacostadiaz added a commit that referenced this pull request Aug 10, 2023
* Fix negative increment

* Fix build with computecpp

* Update dpcpp

* Revert dpcpp version

* Fix sync call

* Add a pointer to the first element of the vector

* Fixes issue with dependencies in nrm2 (#451)

* Fix nrm2

* Remove cout

* Fixes issue with dependencies in TBMV (#454)

This PR fixes an issue with dependencies in TBMV (similar to the fix in #451)
aacostadiaz added a commit that referenced this pull request Aug 11, 2023
* Fix negative increment

* Fix build with computecpp

* Update dpcpp

* Revert dpcpp version

* Fix sync call

* Add a pointer to the first element of the vector

* Fixes issue with dependencies in nrm2 (#451)

* Fix nrm2

* Remove cout

* Fixes issue with dependencies in TBMV (#454)

This PR fixes an issue with dependencies in TBMV (similar to the fix in #451)
@muhammad-tanvir-1211 muhammad-tanvir-1211 deleted the aacosta/fix_nrm2 branch October 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stacked PR is stacked on top of another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants