Fixes issue with dependencies in nrm2 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-tanvir-1211
approved these changes
Jul 31, 2023
aacostadiaz
force-pushed
the
aacosta/fix_negative_inc
branch
from
b0aab2e
to
61de881
Compare
aacostadiaz
force-pushed
the
aacosta/fix_nrm2
branch
from
c231c90
to
114e6d3
Compare
This PR fixes an issue with dependencies in TBMV (similar to the fix in #451)
OuadiElfarouki
approved these changes
Aug 9, 2023
aacostadiaz
added a commit
that referenced
this pull request
Aug 10, 2023
* Fix negative increment * Fix build with computecpp * Update dpcpp * Revert dpcpp version * Fix sync call * Add a pointer to the first element of the vector * Fixes issue with dependencies in nrm2 (#451) * Fix nrm2 * Remove cout * Fixes issue with dependencies in TBMV (#454) This PR fixes an issue with dependencies in TBMV (similar to the fix in #451)
aacostadiaz
added a commit
that referenced
this pull request
Aug 11, 2023
* Fix negative increment * Fix build with computecpp * Update dpcpp * Revert dpcpp version * Fix sync call * Add a pointer to the first element of the vector * Fixes issue with dependencies in nrm2 (#451) * Fix nrm2 * Remove cout * Fixes issue with dependencies in TBMV (#454) This PR fixes an issue with dependencies in TBMV (similar to the fix in #451)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with dependencies in nrm2. Previously, the operations could finish without computing the sqrt operation. This was because the dependency tree was not correctly constructed. This PR fixes the issue by correctly constructing the dependency tree, which ensures that all operations are computed in the correct order.