Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes and new NVIDIA gemm configurations #469

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add fixes and new NVIDIA gemm configurations #469

merged 1 commit into from
Oct 16, 2023

Conversation

pgorlani
Copy link
Collaborator

@pgorlani pgorlani commented Oct 5, 2023

This patch adds new configurations for improving the gemm performance of the NVIDIA_GPU target.

Moreover,

  • remove unnecessary loop unrolls that increased register utilization;
  • allow setting rectangular local matrix sizes;
  • remove the creation of unnecessary workgroups;
  • unroll completely the matrix computation loops for the NVIDIA_GPU target.

muhammad-tanvir-1211
muhammad-tanvir-1211 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@muhammad-tanvir-1211 muhammad-tanvir-1211 merged commit 9c18746 into codeplaysoftware:master Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammad-tanvir-1211 muhammad-tanvir-1211 muhammad-tanvir-1211 approved these changes

@OuadiElfarouki OuadiElfarouki OuadiElfarouki approved these changes

@aacostadiaz aacostadiaz Awaiting requested review from aacostadiaz

@s-Nick s-Nick Awaiting requested review from s-Nick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgorlani @muhammad-tanvir-1211 @OuadiElfarouki