Fix gemm bugs for sm_80 NVIDIA_GPU target
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgorlani
requested review from
muhammad-tanvir-1211,
s-Nick,
OuadiElfarouki and
aacostadiaz
pgorlani
changed the title
sm_80 NVIDIA_GPU targetsm_80 NVIDIA_GPU target
muhammad-tanvir-1211
approved these changes
Oct 13, 2023
OuadiElfarouki
approved these changes
Oct 19, 2023
muhammad-tanvir-1211
merged commit 445764f
into
codeplaysoftware:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
sm_80, global memory data isround_to_tf32in any case even if a non-joint matrix version of_gemmis selected. This rounding causes test failings. This patch splits the class for loading global memory values forgemm_localandgemm_local_joint_matrixfixing the issue.Moreover, this patch prevents symmetric operands and
doubledatatype to be processed bygemm_local_joint_matrixsince it does not support them.