Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce .so library size #475

Conversation

OuadiElfarouki
Copy link
Collaborator

This PR exploits the internal cmake function add_gemm_configuration that helps generate template instantiations of different gemm kernels configurations, by dropping a number of unused cases :

  • symm_a==true and symm_b==true
  • symm_a==true and trans_b==true
  • symm_b==true and trans_a==true

This patch reduces the final .so library file by 25 to 50% across all supported devices.

Copy link
Collaborator

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

Copy link
Collaborator

@s-Nick s-Nick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muhammad-tanvir-1211 muhammad-tanvir-1211 merged commit dd1c388 into codeplaysoftware:master Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants