-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix joint_matrix implementation to match latest api #491
Merged
muhammad-tanvir-1211
merged 22 commits into
codeplaysoftware:master
from
muhammad-tanvir-1211:joint_matrix_fix
Feb 28, 2024
Merged
Fix joint_matrix implementation to match latest api #491
muhammad-tanvir-1211
merged 22 commits into
codeplaysoftware:master
from
muhammad-tanvir-1211:joint_matrix_fix
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-tanvir-1211
requested review from
s-Nick,
pgorlani,
OuadiElfarouki and
aacostadiaz
January 5, 2024 12:38
Closed
muhammad-tanvir-1211
force-pushed
the
joint_matrix_fix
branch
2 times, most recently
from
January 12, 2024 14:57
00d00d7
to
cb06e62
Compare
s-Nick
reviewed
Jan 16, 2024
s-Nick
approved these changes
Jan 16, 2024
OuadiElfarouki
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
muhammad-tanvir-1211
force-pushed
the
joint_matrix_fix
branch
3 times, most recently
from
February 1, 2024 14:22
ba3ca46
to
7985cbd
Compare
pgorlani
reviewed
Feb 1, 2024
pgorlani
reviewed
Feb 1, 2024
muhammad-tanvir-1211
force-pushed
the
joint_matrix_fix
branch
from
February 2, 2024 12:02
59d37a1
to
ec2884c
Compare
* Remove get_wi_data() and replace with joint_matrix_copy and joint_matrix_apply
* Need to fix transpose case
* Updated the load/store file with proper vectorized load/store for future use.
muhammad-tanvir-1211
force-pushed
the
joint_matrix_fix
branch
from
February 6, 2024 17:28
9ddcee5
to
23dff65
Compare
pgorlani
reviewed
Feb 19, 2024
pgorlani
reviewed
Feb 19, 2024
pgorlani
reviewed
Feb 19, 2024
pgorlani
reviewed
Feb 20, 2024
pgorlani
reviewed
Feb 21, 2024
pgorlani
reviewed
Feb 22, 2024
* Fix half tests by changing the initialization values * Reduced the no. of tests executed
* Increase error margin
muhammad-tanvir-1211
merged commit Feb 28, 2024
861b310
into
codeplaysoftware:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
joint_matrix
basedGEMM
implementation to match the api fromintel/llvm
(commit #2a828f49283145433dc9bbbff74cefcb2d2b10dc
).get_wi_data()
calls and replaced them withjoint_matrix_apply()
andjoint_matrix_copy()
calls.joint_matrix_store()
operation performed on the Global pointerC
)batch size > 1
.