Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for SPR/SPR2 BLAS 2 routines #492

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fixes for SPR/SPR2 BLAS 2 routines #492

merged 2 commits into from
Jan 24, 2024

Conversation

pgorlani
Copy link
Collaborator

This patch fixes various aspects of the SPR/SPR2 BLAS2 routines:

  • fix the mapping of the global work-item index to the triangular matrix coordinates by using only integer arithmetic;
  • move method definitions to the proper file;
  • remove unnecessary increment arguments;
  • improve unit tests by randomly generating the matrix and removing the unnecessary memory layout argument;
  • improve documentation.

muhammad-tanvir-1211
muhammad-tanvir-1211 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the comment regarding layout in tests. Thanks.

test/unittest/blas2/blas2_spr_test.cpp Show resolved Hide resolved
OuadiElfarouki
OuadiElfarouki approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@OuadiElfarouki OuadiElfarouki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@muhammad-tanvir-1211 muhammad-tanvir-1211 merged commit 15fc7be into codeplaysoftware:master Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammad-tanvir-1211 muhammad-tanvir-1211 muhammad-tanvir-1211 approved these changes

@OuadiElfarouki OuadiElfarouki OuadiElfarouki approved these changes

@s-Nick s-Nick Awaiting requested review from s-Nick

@aacostadiaz aacostadiaz Awaiting requested review from aacostadiaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgorlani @muhammad-tanvir-1211 @OuadiElfarouki