CP029 Image accessors with format information #131
Conversation
Signed-off-by: Steffen Larsen <[email protected]>
| }; | ||
| template<> struct image_format_type<image_format::b8g8r8a8_unorm> { | ||
| using type = float4; | ||
| }; |
There was a problem hiding this comment.
Could we maybe also define a helper alias:
| }; | |
| }; | |
| template<image_format format> | |
| using image_format_t = typename image_format_type<format>::type; |
There was a problem hiding this comment.
Good call. I have added this and changed the data type of the accessor returned by the new get_accessor to use this.
I'm not completely convinced that image_format_type is the best name for this struct, so I'm open to alternatives.
There was a problem hiding this comment.
Perhaps image_access_type?
There was a problem hiding this comment.
I think that's a good name, though I'm not fond of the _type suffix. I've renamed it to image_access. What do you think?
Signed-off-by: Steffen Larsen <[email protected]>
| }; | ||
| template<> struct image_format_type<image_format::b8g8r8a8_unorm> { | ||
| using type = float4; | ||
| }; |
There was a problem hiding this comment.
Perhaps image_access_type?
| the underlying image and the `image_format` given to `get_access` is one of the | ||
| combinations shown in the following table: | ||
|
|
||
| | `image_channel_type ` | `image_format` | |
There was a problem hiding this comment.
It would be useful to specify the type of image_format_type_t for each value of image_format as well to save cross-referencing it.
There was a problem hiding this comment.
I don't think this would be the table for it, but I could add a new table with the mappings if that would be useful?
Signed-off-by: Steffen Larsen <[email protected]>
Adds an extension for more supported data types for image accessors and a new
get_accessoverload on images that allows for image format information to be known by the accessor at compile-time.