Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): group dependabot PRs and reduce frequency #499

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Nov 7, 2024

This project has zero dependencies, so dependabot PRs are mainly noise. This PR ensures all thirdparty deps are grouped together and changes the frequency from weekly to monthly.

@mafredri mafredri force-pushed the mafredri/chore-update-dependabot branch from 4a551ae to 105128d Compare November 7, 2024 12:11
@mafredri mafredri requested review from matifali and mtojek November 7, 2024 12:12
@mafredri mafredri force-pushed the mafredri/chore-update-dependabot branch from 105128d to bd75926 Compare November 7, 2024 12:16
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise 👍

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we group while keeping the single config?
I guess GitHub doesn't support that.

@mafredri
Copy link
Member Author

mafredri commented Nov 7, 2024

Why can't we group while keeping the single config? I guess GitHub doesn't support that.

I kept the groups separate to signify importance, where importance goes in the order of / > /internal/examples > /internal/thirdparty. We don't have deps in / though, so that's just future-proofing.

Even /internal/examples is just one dep, so that's future proofing as well.

If it's preferable we can just combine the two:

  - package-ecosystem: 'gomod'
    directories:
      - '/internal/examples'
      - '/internal/thirdparty'
    schedule:
      interval: 'monthly'
    commit-message:
      prefix: 'chore'
    labels: []
    groups:
      internal:
        patterns:
          - '*'

Sound better @matifali @mtojek?

EDIT: Combined.

@mafredri mafredri changed the title chore(.github): group dependabot PRs and reduce frequency for thirdpary chore(.github): group dependabot PRs and reduce frequency Nov 7, 2024
@mafredri mafredri merged commit d67767c into master Nov 7, 2024
5 checks passed
@mafredri mafredri deleted the mafredri/chore-update-dependabot branch November 7, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants