Redax 2.0 #99
Closed
Redax 2.0 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollover change
Adds WFsim into 2.0 draft
Actually adds WFsim into 2.0 draft
|
Fixes #84 |
|
The thread pool-based processing isn't fast enough to keep up with even moderate data rates. Probably too many threads trying to have fast access to the same mutex. Even increasing thread caching had little effect. This PR won't become 2.0, but it may inspire it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sweeping and extensive changes to the central processing core of redax. Rather than have individual processing threads that continually poll a central buffer for data packets, a thread pool system is implemented which handles this. Additionally, the waveform simulator is now included, rather than being a separate feature. Some additional minor scaffolding changes are also made, such as a transition away from raw pointers in favor of
std::unique_ptrandstd::shared_ptr.