Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ninja listings #201

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix: ninja listings #201

merged 2 commits into from
Oct 9, 2023

Conversation

danielsp45
Copy link
Member

No description provided.

@reviewpad
Copy link

reviewpad bot commented Oct 9, 2023

AI-Generated Summary: This pull request introduces changes to both source code and tests. The modifications to the BokkenWeb.SkillJSON source file refactor the handling of skills, removing unnecessary step of wrapping skills in a map for function data(). The change seems to simplify the code logic and leads to lesser clutter.

In the test files ninja_json_test.exs and skill_json_test.exs, the changes insert stubbed data to the tests using insert() and insert_list() instead of build functions. This change allows actual creation of test data to serve the purpose of proper testing. Also, a new test case is being added to the Bokken.NinjaJSONTest. This new test case appears to be empty as of now but can be filled with relevant assertions or validations in the future.

In summary, this pull request brings simplifications and enhancements to both the source code and tests in the application.

@danielsp45 danielsp45 merged commit 972b1e4 into main Oct 9, 2023
3 checks passed
@danielsp45 danielsp45 deleted the dp/fix-ninja-controller-bug branch October 9, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants