Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ninja controller and view #203

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: ninja controller and view #203

merged 1 commit into from
Oct 10, 2023

Conversation

ruilopesm
Copy link
Member

No description provided.

@reviewpad
Copy link

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request includes changes to multiple files where the NinjaView was replaced with NinjaJSON. Modifications were done in 'ninja_json.ex', 'auth_view.ex', 'enrollment_view.ex' and 'lecture_view.ex' files. Additionally, the entire file, 'ninja_view.ex', was deleted, which had functions to render JSON views for the 'ninja' model. Several adjustments are made to the 'NinjaJSON' module, including adding the 'Ninja' alias, renaming the function 'guardian_attrs' to 'guardian', and modifying the structure of the data function. The pull request consists of 10 insertions and 68 deletions which overall simplifies the project structure by eliminating the redundant 'NinjaView' module.

@ruilopesm ruilopesm merged commit c9bb38c into main Oct 10, 2023
3 checks passed
@ruilopesm ruilopesm deleted the rl/fix-ninjas branch October 10, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants